* Bug in recent pad patch (96eb371b816c)
@ 2017-01-06 18:06 Cameron Gutman
2017-01-06 18:34 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Cameron Gutman @ 2017-01-06 18:06 UTC (permalink / raw)
To: Dmitry Torokhov, dan.g.tob; +Cc: linux-input, Pavel Rojtberg
It looks like the recent commit in master
96eb371b816c ("Input: xpad - correctly sort vendor id's")
adds a duplicate entry for XPAD_XBOXONE_VENDOR(0x24c6).
You may want to amend that with the following:
diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
index ceb6a58..c06b717 100644
--- a/drivers/input/joystick/xpad.c
+++ b/drivers/input/joystick/xpad.c
@@ -325,7 +325,6 @@ static struct usb_device_id xpad_table[] = {
XPAD_XBOX360_VENDOR(0x12ab), /* X-Box 360 dance pads */
XPAD_XBOX360_VENDOR(0x1430), /* RedOctane X-Box 360 controllers */
XPAD_XBOX360_VENDOR(0x146b), /* BigBen Interactive Controllers */
- XPAD_XBOXONE_VENDOR(0x24c6), /* PowerA Controllers */
XPAD_XBOX360_VENDOR(0x1532), /* Razer Sabertooth */
XPAD_XBOX360_VENDOR(0x15e4), /* Numark X-Box 360 controllers */
XPAD_XBOX360_VENDOR(0x162e), /* Joytech X-Box 360 controllers */
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: Bug in recent pad patch (96eb371b816c)
2017-01-06 18:06 Bug in recent pad patch (96eb371b816c) Cameron Gutman
@ 2017-01-06 18:34 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2017-01-06 18:34 UTC (permalink / raw)
To: Cameron Gutman; +Cc: dan.g.tob, linux-input, Pavel Rojtberg
On Fri, Jan 06, 2017 at 12:06:39PM -0600, Cameron Gutman wrote:
> It looks like the recent commit in master
>
> 96eb371b816c ("Input: xpad - correctly sort vendor id's")
>
> adds a duplicate entry for XPAD_XBOXONE_VENDOR(0x24c6).
>
> You may want to amend that with the following:
Thanks, I amended the offending commit.
>
> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> index ceb6a58..c06b717 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -325,7 +325,6 @@ static struct usb_device_id xpad_table[] = {
> XPAD_XBOX360_VENDOR(0x12ab), /* X-Box 360 dance pads */
> XPAD_XBOX360_VENDOR(0x1430), /* RedOctane X-Box 360 controllers */
> XPAD_XBOX360_VENDOR(0x146b), /* BigBen Interactive Controllers */
> - XPAD_XBOXONE_VENDOR(0x24c6), /* PowerA Controllers */
> XPAD_XBOX360_VENDOR(0x1532), /* Razer Sabertooth */
> XPAD_XBOX360_VENDOR(0x15e4), /* Numark X-Box 360 controllers */
> XPAD_XBOX360_VENDOR(0x162e), /* Joytech X-Box 360 controllers */
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-06 18:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-06 18:06 Bug in recent pad patch (96eb371b816c) Cameron Gutman
2017-01-06 18:34 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).