* [PATCH] Input: synaptics-rmi4: correctly swap clip values if axes are swapped
@ 2017-01-13 17:43 Lucas Stach
2017-01-15 23:23 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Lucas Stach @ 2017-01-13 17:43 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Andrew Duggan, Christopher Heiny, linux-input, Nick Dyer,
Chris Healy, kernel, patchwork-lst
The clip values need the same swapping as the maximium values if the
sensor axes are swapped.
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
drivers/input/rmi4/rmi_2d_sensor.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/input/rmi4/rmi_2d_sensor.c b/drivers/input/rmi4/rmi_2d_sensor.c
index 07007ff8e29f..8bb866c7b985 100644
--- a/drivers/input/rmi4/rmi_2d_sensor.c
+++ b/drivers/input/rmi4/rmi_2d_sensor.c
@@ -144,8 +144,13 @@ static void rmi_2d_sensor_set_input_params(struct rmi_2d_sensor *sensor)
int input_flags = 0;
if (sensor->report_abs) {
- if (sensor->axis_align.swap_axes)
+ if (sensor->axis_align.swap_axes) {
swap(sensor->max_x, sensor->max_y);
+ swap(sensor->axis_align.clip_x_low,
+ sensor->axis_align.clip_y_low);
+ swap(sensor->axis_align.clip_x_high,
+ sensor->axis_align.clip_y_high);
+ }
sensor->min_x = sensor->axis_align.clip_x_low;
if (sensor->axis_align.clip_x_high)
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Input: synaptics-rmi4: correctly swap clip values if axes are swapped
2017-01-13 17:43 [PATCH] Input: synaptics-rmi4: correctly swap clip values if axes are swapped Lucas Stach
@ 2017-01-15 23:23 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2017-01-15 23:23 UTC (permalink / raw)
To: Lucas Stach
Cc: Andrew Duggan, Christopher Heiny, linux-input, Nick Dyer,
Chris Healy, kernel, patchwork-lst
On Fri, Jan 13, 2017 at 06:43:24PM +0100, Lucas Stach wrote:
> The clip values need the same swapping as the maximium values if the
> sensor axes are swapped.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Applied, thank you.
> ---
> drivers/input/rmi4/rmi_2d_sensor.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/input/rmi4/rmi_2d_sensor.c b/drivers/input/rmi4/rmi_2d_sensor.c
> index 07007ff8e29f..8bb866c7b985 100644
> --- a/drivers/input/rmi4/rmi_2d_sensor.c
> +++ b/drivers/input/rmi4/rmi_2d_sensor.c
> @@ -144,8 +144,13 @@ static void rmi_2d_sensor_set_input_params(struct rmi_2d_sensor *sensor)
> int input_flags = 0;
>
> if (sensor->report_abs) {
> - if (sensor->axis_align.swap_axes)
> + if (sensor->axis_align.swap_axes) {
> swap(sensor->max_x, sensor->max_y);
> + swap(sensor->axis_align.clip_x_low,
> + sensor->axis_align.clip_y_low);
> + swap(sensor->axis_align.clip_x_high,
> + sensor->axis_align.clip_y_high);
> + }
>
> sensor->min_x = sensor->axis_align.clip_x_low;
> if (sensor->axis_align.clip_x_high)
> --
> 2.11.0
>
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-15 23:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-13 17:43 [PATCH] Input: synaptics-rmi4: correctly swap clip values if axes are swapped Lucas Stach
2017-01-15 23:23 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).