From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Christopher Heiny <cheiny@synaptics.com>,
Nick Dyer <nick@shmanahar.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-input@vger.kernel.org,
Andrew Duggan <aduggan@synaptics.com>
Subject: Re: [PATCH] Input: synaptics-rmi4 - make F03 a tristate symbol
Date: Sun, 15 Jan 2017 15:39:30 -0800 [thread overview]
Message-ID: <20170115233930.GG23285@dtor-ws> (raw)
In-Reply-To: <CAK8P3a3cTu8CtxGoSBqEerjN-=5ohTH0KUmnrG5nLcJHYu0yiQ@mail.gmail.com>
On Sat, Jan 14, 2017 at 01:09:57PM +0100, Arnd Bergmann wrote:
> On Jan 13, 2017 10:42 PM, "Dmitry Torokhov" <dmitry.torokhov@gmail.com> wrote:
> > On Fri, Jan 13, 2017 at 10:34:32PM +0100, Arnd Bergmann wrote:
> > > config RMI4_F03_SERIO
> > > tristate
> > > depends on RMI4_CORE
> > > depends on RMI4_F03
> > > default RMI4_CORE
> > > select SERIO
> > >
> > > As that avoids the 'depends on SERIO=y || RMI4_CORE=SERIO' statement that
> > > is different from the other SERIO users, it keeps it all in one place,
> > > and it doesn't
> > > prevent you from seeing the RMI4_F03 symbol when SERIO=m.
> > Hmm, if this works and resilient with user changing symbols after
> > they've been auto-selected then I like it. How can we run it through
> > multitude of randconfigs?
>
> I've successfully run it over night on a few hundred randconfig builds without
> problems now, so I'm pretty confident it works.
>
> The hidden option will ensure the configuration is always valid even when
> the user changes it, the only thing that can be unexpected is the same as
> every 'select': when you enable this option, SERIO will get turned on, and
> when you disable it again after leaving 'menuconfig', it stays on.
Great. Could you please send me real patch and I'll get it to Linus?
Thanks.
--
Dmitry
prev parent reply other threads:[~2017-01-15 23:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 12:16 [PATCH] Input: synaptics-rmi4 - make F03 a tristate symbol Arnd Bergmann
2017-01-11 0:39 ` Andrew Duggan
2017-01-11 15:39 ` Arnd Bergmann
2017-01-11 16:28 ` Benjamin Tissoires
2017-01-11 16:54 ` Arnd Bergmann
2017-01-11 17:48 ` Benjamin Tissoires
2017-01-11 19:27 ` Christopher Heiny
2017-01-13 0:42 ` Andrew Duggan
2017-01-13 21:14 ` Arnd Bergmann
2017-01-13 6:22 ` Dmitry Torokhov
2017-01-13 21:06 ` Arnd Bergmann
2017-01-13 21:15 ` Dmitry Torokhov
2017-01-13 21:34 ` Arnd Bergmann
2017-01-13 21:42 ` Dmitry Torokhov
2017-01-14 12:09 ` Arnd Bergmann
2017-01-15 23:39 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170115233930.GG23285@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=aduggan@synaptics.com \
--cc=arnd@arndb.de \
--cc=cheiny@synaptics.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nick@shmanahar.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).