From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH v7 2/3] input: tm2-touchkey: Add touchkey driver support for TM2 Date: Wed, 18 Jan 2017 14:47:11 -0800 Message-ID: <20170118224711.GB11881@dtor-ws> References: <1484632479-3111-1-git-send-email-jcsing.lee@samsung.com> <1484632479-3111-3-git-send-email-jcsing.lee@samsung.com> <20170117172047.47535bj5xd6toayu@kozik-lap> <20170117181056.mrwyudslfgh2wfms@kozik-lap> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20170117181056.mrwyudslfgh2wfms@kozik-lap> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Krzysztof Kozlowski Cc: Mark Rutland , "devicetree@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , Chanwoo Choi , Catalin Marinas , Jaechul Lee , Will Deacon , lkml , Rob Herring , Javier Martinez Canillas , Kukjin Kim , Andi Shyti , "linux-input@vger.kernel.org" , =?utf-8?B?7J207J6s7LKg?= , Beomho Seo , "linux-arm-kernel@lists.infradead.org" List-Id: linux-input@vger.kernel.org On Tue, Jan 17, 2017 at 08:10:56PM +0200, Krzysztof Kozlowski wrote: > On Tue, Jan 17, 2017 at 10:06:27AM -0800, Dmitry Torokhov wrote: > > On Tue, Jan 17, 2017 at 9:20 AM, Krzysztof Kozlowski wrote: > > > On Tue, Jan 17, 2017 at 02:54:38PM +0900, Jaechul Lee wrote: > > >> This patch adds support for the TM2 touch key and led > > >> functionality. > > >> > > >> The driver interfaces with userspace through an input device and > > >> reports KEY_PHONE and KEY_BACK event types. LED brightness can be > > >> controlled by "/sys/class/leds/tm2-touchkey/brightness". > > >> > > >> Signed-off-by: Beomho Seo > > >> Signed-off-by: Jaechul Lee > > >> Reviewed-by: Javier Martinez Canillas > > >> Reviewed-by: Andi Shyti > > >> Reviewed-by: Chanwoo Choi > > >> Tested-by: Chanwoo Choi > > >> Acked-by: Krzysztof Kozlowski > > >> Signed-off-by: Dmitry Torokhov > > > > > > This looks unusual. How did Dmitry's Sob end here? > > > > I sent Jaechul a version of the patch to try out. > > Ah, makes sense then. I picked up (and folded) the binding doc and driver patches, DTS should go through some other tree I believe. Thanks. -- Dmitry