From: Thierry Reding <thierry.reding@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, David Lechner <david@lechnology.com>,
linux-kernel@vger.kernel.org,
Frieder Schrempf <frieder.schrempf@exceet.de>
Subject: Re: [PATCH v2 6/7] Input: pwm-beeper - add optional amplifier regulator
Date: Fri, 20 Jan 2017 11:19:16 +0100 [thread overview]
Message-ID: <20170120101916.GF3824@ulmo.ba.sec> (raw)
In-Reply-To: <20170119224057.9995-6-dmitry.torokhov@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 844 bytes --]
On Thu, Jan 19, 2017 at 02:40:56PM -0800, Dmitry Torokhov wrote:
[...]
> diff --git a/drivers/input/misc/pwm-beeper.c b/drivers/input/misc/pwm-beeper.c
> index 9964c46468d3..7b213e0ab06c 100644
> --- a/drivers/input/misc/pwm-beeper.c
> +++ b/drivers/input/misc/pwm-beeper.c
> @@ -14,6 +14,7 @@
> */
>
> #include <linux/input.h>
> +#include <linux/regulator/consumer.h>
> #include <linux/module.h>
> #include <linux/kernel.h>
> #include <linux/of.h>
> @@ -25,30 +26,59 @@
> struct pwm_beeper {
> struct input_dev *input;
> struct pwm_device *pwm;
> + struct regulator *amplifier;
> struct work_struct work;
> unsigned long period;
> bool suspended;
> + bool amplifier_on;
Why do you need to track this? I thought regulator_enable() and
regulator_disable() were already reference counted?
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-01-20 10:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 22:40 [PATCH v2 1/7] Input: pwm-beeper - remove calls to legacy pwm_request API Dmitry Torokhov
2017-01-19 22:40 ` [PATCH v2 2/7] Input: pwm-beeper - switch to using managed resources Dmitry Torokhov
2017-01-20 10:10 ` Thierry Reding
2017-01-19 22:40 ` [PATCH v2 3/7] Input: pwm-beeper - use input_set_capability() Dmitry Torokhov
2017-01-20 10:12 ` Thierry Reding
2017-01-19 22:40 ` [PATCH v2 4/7] Input: pwm-beeper - fix race when suspending Dmitry Torokhov
2017-01-20 10:14 ` Thierry Reding
2017-01-19 22:40 ` [PATCH v2 5/7] Input: pwm-beeper - suppress error message on probe defer Dmitry Torokhov
2017-01-20 10:16 ` Thierry Reding
2017-01-20 18:43 ` David Lechner
2017-01-19 22:40 ` [PATCH v2 6/7] Input: pwm-beeper - add optional amplifier regulator Dmitry Torokhov
2017-01-20 10:19 ` Thierry Reding [this message]
2017-01-20 17:47 ` Dmitry Torokhov
2017-01-19 22:40 ` [PATCH v2 7/7] Input: pwm-beeper - switch to using "atomic" PWM API Dmitry Torokhov
2017-01-20 10:23 ` Thierry Reding
2017-01-20 10:08 ` [PATCH v2 1/7] Input: pwm-beeper - remove calls to legacy pwm_request API Thierry Reding
2017-01-20 19:37 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170120101916.GF3824@ulmo.ba.sec \
--to=thierry.reding@gmail.com \
--cc=david@lechnology.com \
--cc=dmitry.torokhov@gmail.com \
--cc=frieder.schrempf@exceet.de \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).