Re: [PATCH 1/2] Input: soc_button_array - Set input device name

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Mon, Jan 09, 2017 at 06:57:06PM +0100, Hans de Goede wrote:
> On some tablets using the soc_button_array driver the buttons do not
> follow the standard home, power, volume_up, volume_down, rotation_lock
> button order as published by Microsoft.
> 
> We can use the existing udev hwdb mechanism to fix this up, but then
> the created devices must have a unique name, therefor this commit adds
> a unique name for the 2 created gpio-keys input devices.

Why does it have to have unique name? You should be able to match on
other input device properties, for example ATTR{capabilities/ev} or
ATTR{capabilities/keys} to identify the device you want to adjust.

> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  drivers/input/misc/soc_button_array.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/input/misc/soc_button_array.c b/drivers/input/misc/soc_button_array.c
> index 9bc1b20..d2e5186 100644
> --- a/drivers/input/misc/soc_button_array.c
> +++ b/drivers/input/misc/soc_button_array.c
> @@ -113,6 +113,11 @@ soc_button_device_create(struct platform_device *pdev,
>  	gpio_keys_pdata->nbuttons = n_buttons;
>  	gpio_keys_pdata->rep = autorepeat;
>  
> +	if (autorepeat)
> +		gpio_keys_pdata->name = "SoC Button Array (autorepeat buttons)";
> +	else
> +		gpio_keys_pdata->name = "SoC Button Array";
> +
>  	pd = platform_device_alloc("gpio-keys", PLATFORM_DEVID_AUTO);
>  	if (!pd) {
>  		error = -ENOMEM;
> -- 
> 2.9.3
> 

Thanks.

-- 
Dmitry