From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "russianneuromancer @ ya . ru" <russianneuromancer@ya.ru>,
Gregor Riepl <onitake@gmail.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH 2/2] Input: gpio-keys - Add support for setkeycode
Date: Sat, 21 Jan 2017 11:49:09 -0800 [thread overview]
Message-ID: <20170121194909.GE36944@dtor-ws> (raw)
In-Reply-To: <20170109175700.12811-2-hdegoede@redhat.com>
On Mon, Jan 09, 2017 at 06:57:00PM +0100, Hans de Goede wrote:
> gpio-keys input devices created by the soc_button_array driver are
> configured with key-codes based on ACPI provided information.
>
> Unfortunately on some tablets this info is wrong, and we need to have
> a quirk to fix things up.
>
> Add support for input_setkeycode to the gpio-keys driver, so that
> the existing udev hwdb mechanism can be used to fix things up on these
> tablets.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Applied with minor edits:
>
> + ddata->keymap = devm_kzalloc(dev,
> + pdata->nbuttons * sizeof(unsigned short),
> + GFP_KERNEL);
Changed to devm_kcalloc().
> + bdata->code = &ddata->keymap[i];
Pushed into gpio_keys_setup_key().
Thanks.
--
Dmitry
prev parent reply other threads:[~2017-01-21 19:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 17:56 [PATCH 1/2] Input: gpio_keys - Do not report wake button presses as evdev events Hans de Goede
2017-01-09 17:57 ` [PATCH 2/2] Input: gpio-keys - Add support for setkeycode Hans de Goede
2017-01-21 19:49 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170121194909.GE36944@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=onitake@gmail.com \
--cc=russianneuromancer@ya.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox