From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
Darren Hart <dvhart@infradead.org>,
"russianneuromancer @ ya . ru" <russianneuromancer@ya.ru>,
Gregor Riepl <onitake@gmail.com>,
linux-input <linux-input@vger.kernel.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH v3] platform/x86: add support for devices with Silead touchscreens
Date: Sun, 22 Jan 2017 14:22:20 -0800 [thread overview]
Message-ID: <20170122222220.GB31009@dtor-ws> (raw)
In-Reply-To: <CAHp75Vcv077rpufZYSr9jpphT9ureJ4t1=9PRNeX_RkcE6Ri9Q@mail.gmail.com>
On Sun, Jan 22, 2017 at 06:49:11PM +0200, Andy Shevchenko wrote:
> On Sun, Jan 22, 2017 at 5:25 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> > On ACPI based tablets, the ACPI touchscreen node only contains info on
> > the gpio and the irq, and is missing any info on the axis. This info is
> > expected to be built into the tablet model specific version of the driver
> > shipped with the os-image for the device.
> >
> > Add support for getting the missing info from a table built into the
> > driver, using dmi data to identify which entry of the table to use and
> > add info for the CUBE iwork8 Air and Jumper EZpad mini3 tablets on which
> > this code was tested / developed.
> >
> > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=187531
> > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> > [dmitry.torokhov@gmail.com: Move to platform/x86]
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>
> Few nitpicks below. After addressing them
> Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>
> (in case Dmitry would like to push this via input subsystem)
Nope ;) There was a reason why I did not want to have it in the driver
proper.
It can go in separately, there are no changes needed in the driver to
make use of these properties.
Thanks.
--
Dmitry
prev parent reply other threads:[~2017-01-22 22:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-22 15:25 [PATCH v3] platform/x86: add support for devices with Silead touchscreens Hans de Goede
2017-01-22 16:49 ` Andy Shevchenko
2017-01-22 20:05 ` Hans de Goede
2017-01-22 22:22 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170122222220.GB31009@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=dvhart@infradead.org \
--cc=hdegoede@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=onitake@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=russianneuromancer@ya.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).