* [PATCH] Input: max11801_ts - drop call to input_set_drvdata()
@ 2017-01-22 7:38 Dmitry Torokhov
2017-01-22 11:25 ` Guenter Roeck
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Torokhov @ 2017-01-22 7:38 UTC (permalink / raw)
To: linux-input; +Cc: Guenter Roeck, Zhang Jiejing, linux-kernel
Nobody calls input_get_drvdata() so setting it is not required.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/touchscreen/max11801_ts.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/touchscreen/max11801_ts.c b/drivers/input/touchscreen/max11801_ts.c
index d87b89da114e..a595ae5284e3 100644
--- a/drivers/input/touchscreen/max11801_ts.c
+++ b/drivers/input/touchscreen/max11801_ts.c
@@ -199,7 +199,6 @@ static int max11801_ts_probe(struct i2c_client *client,
__set_bit(BTN_TOUCH, input_dev->keybit);
input_set_abs_params(input_dev, ABS_X, 0, MAX11801_MAX_X, 0, 0);
input_set_abs_params(input_dev, ABS_Y, 0, MAX11801_MAX_Y, 0, 0);
- input_set_drvdata(input_dev, data);
max11801_ts_phy_init(data);
--
2.11.0.483.g087da7b7c-goog
--
Dmitry
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: max11801_ts - drop call to input_set_drvdata()
2017-01-22 7:38 [PATCH] Input: max11801_ts - drop call to input_set_drvdata() Dmitry Torokhov
@ 2017-01-22 11:25 ` Guenter Roeck
2017-01-22 22:31 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Guenter Roeck @ 2017-01-22 11:25 UTC (permalink / raw)
To: Dmitry Torokhov, linux-input; +Cc: Zhang Jiejing, linux-kernel
On 01/21/2017 11:38 PM, Dmitry Torokhov wrote:
> Nobody calls input_get_drvdata() so setting it is not required.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Acked-by: Guenter Roeck <linux@roeck-us.net>
Surprisingly, there is about a dozen of those. I'll send a series of
coccinelle generated patches later.
Guenter
> ---
> drivers/input/touchscreen/max11801_ts.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/max11801_ts.c b/drivers/input/touchscreen/max11801_ts.c
> index d87b89da114e..a595ae5284e3 100644
> --- a/drivers/input/touchscreen/max11801_ts.c
> +++ b/drivers/input/touchscreen/max11801_ts.c
> @@ -199,7 +199,6 @@ static int max11801_ts_probe(struct i2c_client *client,
> __set_bit(BTN_TOUCH, input_dev->keybit);
> input_set_abs_params(input_dev, ABS_X, 0, MAX11801_MAX_X, 0, 0);
> input_set_abs_params(input_dev, ABS_Y, 0, MAX11801_MAX_Y, 0, 0);
> - input_set_drvdata(input_dev, data);
>
> max11801_ts_phy_init(data);
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Input: max11801_ts - drop call to input_set_drvdata()
2017-01-22 11:25 ` Guenter Roeck
@ 2017-01-22 22:31 ` Dmitry Torokhov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2017-01-22 22:31 UTC (permalink / raw)
To: Guenter Roeck; +Cc: linux-input, Zhang Jiejing, linux-kernel
On Sun, Jan 22, 2017 at 03:25:57AM -0800, Guenter Roeck wrote:
> On 01/21/2017 11:38 PM, Dmitry Torokhov wrote:
> >Nobody calls input_get_drvdata() so setting it is not required.
> >
> >Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
>
> Acked-by: Guenter Roeck <linux@roeck-us.net>
>
> Surprisingly, there is about a dozen of those. I'll send a series of
> coccinelle generated patches later.
Cool, thanks.
>
> Guenter
>
> >---
> > drivers/input/touchscreen/max11801_ts.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> >diff --git a/drivers/input/touchscreen/max11801_ts.c b/drivers/input/touchscreen/max11801_ts.c
> >index d87b89da114e..a595ae5284e3 100644
> >--- a/drivers/input/touchscreen/max11801_ts.c
> >+++ b/drivers/input/touchscreen/max11801_ts.c
> >@@ -199,7 +199,6 @@ static int max11801_ts_probe(struct i2c_client *client,
> > __set_bit(BTN_TOUCH, input_dev->keybit);
> > input_set_abs_params(input_dev, ABS_X, 0, MAX11801_MAX_X, 0, 0);
> > input_set_abs_params(input_dev, ABS_Y, 0, MAX11801_MAX_Y, 0, 0);
> >- input_set_drvdata(input_dev, data);
> >
> > max11801_ts_phy_init(data);
> >
> >
>
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-22 22:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-22 7:38 [PATCH] Input: max11801_ts - drop call to input_set_drvdata() Dmitry Torokhov
2017-01-22 11:25 ` Guenter Roeck
2017-01-22 22:31 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).