linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: ardinar23@gmail.com
Cc: linux-input@vger.kernel.org, Jiri Kosina <jkosina@suse.cz>
Subject: Re: [PATCH] hid-lg: Fixes immediate disconnection of Logitech Rumblepad 2
Date: Tue, 24 Jan 2017 09:07:22 +0100	[thread overview]
Message-ID: <20170124080722.GF9285@mail.corp.redhat.com> (raw)
In-Reply-To: <72472ae2-17b1-7e1b-11f2-3ff00c7c6d87@gmail.com>

Hi,

On Jan 20 2017 or thereabouts, Ardinartsev Nikita wrote:
> hid-lg: Fixes immediate disconnection of Logitech Rumblepad 2
> 
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=117091

Having a bug link is fine, but please also write a short description of
what you are trying to solve.

> Signed-off-by: Ardinartsev Nikita <ardinar23@gmail.com>
> ---
>  drivers/hid/hid-lg.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-lg.c b/drivers/hid/hid-lg.c
> index c5c5fbe..f1afb6b 100644
> --- a/drivers/hid/hid-lg.c
> +++ b/drivers/hid/hid-lg.c
> @@ -872,7 +872,7 @@ static const struct hid_device_id lg_devices[] = {
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
> USB_DEVICE_ID_LOGITECH_WINGMAN_FFG),
>  		.driver_data = LG_NOGET | LG_FF4 },
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
> USB_DEVICE_ID_LOGITECH_RUMBLEPAD2),
> -		.driver_data = LG_FF2 },
> +		.driver_data = LG_FF2 | LG_NOGET },

This looks OK, but I'd like to get the confirmation first that the
rumble effects are still working.

Cheers,
Benjamin

>  	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
> USB_DEVICE_ID_LOGITECH_FLIGHT_SYSTEM_G940),
>  		.driver_data = LG_FF3 },
>  	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_SPACENAVIGATOR),
> -- 
> 2.7.4

  reply	other threads:[~2017-01-24  8:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-20 19:20 [PATCH] hid-lg: Fixes immediate disconnection of Logitech Rumblepad 2 Ardinartsev Nikita
2017-01-24  8:07 ` Benjamin Tissoires [this message]
     [not found]   ` <4444f83d-f7d2-0bed-5dd2-e44a068ffbfd@gmail.com>
2017-01-26  8:29     ` Benjamin Tissoires

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170124080722.GF9285@mail.corp.redhat.com \
    --to=benjamin.tissoires@redhat.com \
    --cc=ardinar23@gmail.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).