* [PATCH v2] hid-lg: Fix immediate disconnection of Logitech Rumblepad 2
@ 2017-01-26 13:54 Ardinartsev Nikita
2017-01-26 14:17 ` Benjamin Tissoires
2017-01-26 20:59 ` Jiri Kosina
0 siblings, 2 replies; 3+ messages in thread
From: Ardinartsev Nikita @ 2017-01-26 13:54 UTC (permalink / raw)
To: linux-input; +Cc: Benjamin Tissoires, Jiri Kosina
hid-lg: Fix immediate disconnection of Logitech Rumblepad 2
With NOGET quirk Logitech F510 is now fully workable in dinput mode
including rumble effects (according to fftest).
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=117091
Signed-off-by: Ardinartsev Nikita <ardinar23@gmail.com>
---
drivers/hid/hid-lg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-lg.c b/drivers/hid/hid-lg.c
index c5c5fbe..52026dc 100644
--- a/drivers/hid/hid-lg.c
+++ b/drivers/hid/hid-lg.c
@@ -872,7 +872,7 @@ static const struct hid_device_id lg_devices[] = {
{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
USB_DEVICE_ID_LOGITECH_WINGMAN_FFG),
.driver_data = LG_NOGET | LG_FF4 },
{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
USB_DEVICE_ID_LOGITECH_RUMBLEPAD2),
- .driver_data = LG_FF2 },
+ .driver_data = LG_NOGET | LG_FF2 },
{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
USB_DEVICE_ID_LOGITECH_FLIGHT_SYSTEM_G940),
.driver_data = LG_FF3 },
{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_SPACENAVIGATOR),
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] hid-lg: Fix immediate disconnection of Logitech Rumblepad 2
2017-01-26 13:54 [PATCH v2] hid-lg: Fix immediate disconnection of Logitech Rumblepad 2 Ardinartsev Nikita
@ 2017-01-26 14:17 ` Benjamin Tissoires
2017-01-26 20:59 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Benjamin Tissoires @ 2017-01-26 14:17 UTC (permalink / raw)
To: ardinar23; +Cc: linux-input, Jiri Kosina
On Jan 26 2017 or thereabouts, Ardinartsev Nikita wrote:
> hid-lg: Fix immediate disconnection of Logitech Rumblepad 2
>
> With NOGET quirk Logitech F510 is now fully workable in dinput mode
> including rumble effects (according to fftest).
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=117091
> Signed-off-by: Ardinartsev Nikita <ardinar23@gmail.com>
> ---
Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> drivers/hid/hid-lg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/hid-lg.c b/drivers/hid/hid-lg.c
> index c5c5fbe..52026dc 100644
> --- a/drivers/hid/hid-lg.c
> +++ b/drivers/hid/hid-lg.c
> @@ -872,7 +872,7 @@ static const struct hid_device_id lg_devices[] = {
> { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
> USB_DEVICE_ID_LOGITECH_WINGMAN_FFG),
> .driver_data = LG_NOGET | LG_FF4 },
> { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
> USB_DEVICE_ID_LOGITECH_RUMBLEPAD2),
> - .driver_data = LG_FF2 },
> + .driver_data = LG_NOGET | LG_FF2 },
> { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
> USB_DEVICE_ID_LOGITECH_FLIGHT_SYSTEM_G940),
> .driver_data = LG_FF3 },
> { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_SPACENAVIGATOR),
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] hid-lg: Fix immediate disconnection of Logitech Rumblepad 2
2017-01-26 13:54 [PATCH v2] hid-lg: Fix immediate disconnection of Logitech Rumblepad 2 Ardinartsev Nikita
2017-01-26 14:17 ` Benjamin Tissoires
@ 2017-01-26 20:59 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2017-01-26 20:59 UTC (permalink / raw)
To: ardinar23; +Cc: linux-input, Benjamin Tissoires
On Thu, 26 Jan 2017, Ardinartsev Nikita wrote:
> hid-lg: Fix immediate disconnection of Logitech Rumblepad 2
>
> With NOGET quirk Logitech F510 is now fully workable in dinput mode including
> rumble effects (according to fftest).
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=117091
> Signed-off-by: Ardinartsev Nikita <ardinar23@gmail.com>
The patch has been line-wrapped by your mail clinet. Please fix that up
for any future submissions.
I've now fixed it up manually on my side and applied, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-26 20:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-26 13:54 [PATCH v2] hid-lg: Fix immediate disconnection of Logitech Rumblepad 2 Ardinartsev Nikita
2017-01-26 14:17 ` Benjamin Tissoires
2017-01-26 20:59 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).