From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Paulo Costa <me@paulo.costa.nom.br>
Cc: "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>
Subject: Re: [PATCH] Input: add LED_0..LED_15 define
Date: Sun, 12 Feb 2017 17:31:55 -0800 [thread overview]
Message-ID: <20170213013155.GC528@dtor-ws> (raw)
In-Reply-To: <CADbEYbncQyFLg7Jq3pGBc2JfOh+2H6FYZ+XPRjnZEcEm7uVVtQ@mail.gmail.com>
On Sun, Feb 12, 2017 at 11:03:03PM -0200, Paulo Costa wrote:
> 2017-02-10 22:54 GMT-02:00 Dmitry Torokhov <dmitry.torokhov@gmail.com>:
> > Hi Paulo,
> >
> > On Tue, Feb 7, 2017 at 4:41 PM, Paulo Costa <me@paulo.costa.nom.br> wrote:
> >> Some input devices have many controllable leds that don't fit any standard function (e.g., the Wiimote has 4 controllable LEDs)
> >>
> >> Just as we have BTN_0..BTN_9 for generic buttons, LED_0...LED_15 can now be used to control generic leds.
> >
> > Generic LEDs should use LED subsystem; we are not going to be adding
> > more LED definitions to input.
> >
> > Thanks.
> >
> > --
> > Dmitry
>
> Hello, Dmitry,
>
> IMHO, whenever those leds are part of a bigger input device,
> using EV_LED makes more sense.
>
> But it's your call, thanks for looking into it.
Yes, we even re-exported the "original" input LEDs as "standard" LEDs.
Other drovers are also using "standard" LEDs - xpad.c, etc.
Thanks.
--
Dmitry
prev parent reply other threads:[~2017-02-13 1:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 0:41 [PATCH] Input: add LED_0..LED_15 define Paulo Costa
2017-02-11 0:54 ` Dmitry Torokhov
2017-02-13 1:03 ` Paulo Costa
2017-02-13 1:31 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170213013155.GC528@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=me@paulo.costa.nom.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).