From: Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "H. Nikolaus Schaller" <hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
Cc: "Sebastian Reichel" <sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Mark Rutland" <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
"Benoît Cousson"
<bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
"Tony Lindgren" <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
"Russell King" <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
"Arnd Bergmann" <arnd-r2nGTMty4D4@public.gmane.org>,
"Michael Welling" <mwelling-EkmVulN54Sk@public.gmane.org>,
"Mika Penttilä"
<mika.penttila-MRsr7dthA9VWk0Htik3J/w@public.gmane.org>,
"Javier Martinez Canillas"
<javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>,
"Igor Grinberg"
<grinberg-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org>,
"Andrew F. Davis" <afd-l0cyMroinI0@public.gmane.org>,
"Mark Brown" <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Jonathan Cameron"
<jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"Alexander Stein"
<alexander.stein-93q1YBGzJSMe9JSWTWOYM3xStJ4P+DSV@public.gmane.org>,
"Eric Engestrom" <eric-op+oiCINJLTt9jDmeYuA0g@public.gmane.org>,
"Hans de Goede"
<hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"Benjamin Tissoires"
<benjamin.tissoires-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH v9 2/8] drivers:input:tsc2007: check for presence and power down tsc2007 during probe
Date: Fri, 17 Feb 2017 12:52:44 -0800 [thread overview]
Message-ID: <20170217205244.GG13050@dtor-ws> (raw)
In-Reply-To: <f39f47ebef2224bd73e114ee529768756bb8972a.1482936802.git.hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
On Wed, Dec 28, 2016 at 03:53:17PM +0100, H. Nikolaus Schaller wrote:
> 1. check if chip is really present and don't succeed if it isn't.
> 2. if it succeeds, power down the chip until accessed
>
> Signed-off-by: H. Nikolaus Schaller <hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
Applied, thank you.
> ---
> drivers/input/touchscreen/tsc2007.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/input/touchscreen/tsc2007.c b/drivers/input/touchscreen/tsc2007.c
> index c1d9593..76b462b 100644
> --- a/drivers/input/touchscreen/tsc2007.c
> +++ b/drivers/input/touchscreen/tsc2007.c
> @@ -529,6 +529,14 @@ static int tsc2007_probe(struct i2c_client *client,
>
> tsc2007_stop(ts);
>
> + /* power down the chip (TSC2007_SETUP does not ACK on I2C) */
> + err = tsc2007_xfer(ts, PWRDOWN);
> + if (err < 0) {
> + dev_err(&client->dev,
> + "Failed to setup chip: %d\n", err);
> + return err; /* usually, chip does not respond */
> + }
> +
> err = input_register_device(input_dev);
> if (err) {
> dev_err(&client->dev,
> --
> 2.7.3
>
--
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-02-17 20:52 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-28 14:53 [PATCH v9 0/8] drivers: touchscreen: tsc2007 and ads7846/tsc2046 improvements (use common touchscreen bindings, pre-calibration, spi fix and provide iio raw values) H. Nikolaus Schaller
2016-12-28 14:53 ` [PATCH v9 1/8] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation H. Nikolaus Schaller
2017-01-09 17:43 ` Rob Herring
2017-01-28 19:33 ` Dmitry Torokhov
2017-01-28 21:44 ` H. Nikolaus Schaller
2017-02-17 20:40 ` Dmitry Torokhov
2017-02-18 3:22 ` Sebastian Reichel
2017-02-18 11:33 ` H. Nikolaus Schaller
[not found] ` <95E59EB0-6F96-40BB-B74C-9CD56DDD7783-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2017-02-18 23:44 ` Sebastian Reichel
2017-02-19 12:07 ` H. Nikolaus Schaller
[not found] ` <FA96689F-AFD0-4FC9-95D9-639299341C8B-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2017-02-19 20:15 ` Sebastian Reichel
2017-02-20 16:49 ` H. Nikolaus Schaller
2017-02-18 7:45 ` [Letux-kernel] " Andreas Kemnade
2017-02-18 9:15 ` Pavel Machek
2017-02-18 11:33 ` H. Nikolaus Schaller
2017-02-18 18:08 ` Pavel Machek
2017-02-18 19:17 ` H. Nikolaus Schaller
2017-02-18 22:54 ` Pavel Machek
2017-02-19 12:05 ` H. Nikolaus Schaller
2017-02-19 14:17 ` Pavel Machek
2017-02-19 17:04 ` H. Nikolaus Schaller
2017-02-19 17:15 ` Pavel Machek
2017-02-19 17:51 ` H. Nikolaus Schaller
2017-02-19 19:05 ` Pavel Machek
2017-02-19 19:31 ` H. Nikolaus Schaller
[not found] ` <EB41EEED-0D94-473F-944F-757B25350A4C-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2017-02-19 20:57 ` Pavel Machek
2017-02-19 22:01 ` H. Nikolaus Schaller
2017-02-19 22:19 ` Pavel Machek
2017-02-20 16:50 ` H. Nikolaus Schaller
[not found] ` <6610D852-4717-47A7-BFDE-52C8E9E614BB-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2017-02-20 19:29 ` Pavel Machek
2017-02-20 20:20 ` H. Nikolaus Schaller
2017-02-20 22:26 ` Petr Cvek
[not found] ` <e3dd020e-8590-6e65-9151-b5f1492debcb-qphu/3gb4gc@public.gmane.org>
2017-02-21 8:29 ` H. Nikolaus Schaller
2017-02-19 22:29 ` [Letux-kernel] " Andreas Kemnade
2017-02-19 22:39 ` Pavel Machek
2017-02-20 16:50 ` H. Nikolaus Schaller
2017-02-20 19:32 ` Pavel Machek
2017-02-20 20:22 ` H. Nikolaus Schaller
[not found] ` <776DC6E2-5D58-40F4-8866-39D9002EF772-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2017-02-20 20:50 ` H. Nikolaus Schaller
2017-02-18 11:32 ` H. Nikolaus Schaller
[not found] ` <558407EE-4884-4CC3-9098-79DC4B222868-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2017-02-20 1:07 ` Dmitry Torokhov
2017-02-20 16:50 ` H. Nikolaus Schaller
2017-02-20 19:42 ` Pali Rohár
2017-02-20 20:35 ` H. Nikolaus Schaller
[not found] ` <53529A9D-E2AA-405C-A12A-716984D2CDBC-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2017-02-20 21:07 ` Pali Rohár
2017-02-20 21:24 ` H. Nikolaus Schaller
[not found] ` <A77657DA-BFF3-4A4E-9302-047B77072F3A-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2017-02-20 21:54 ` Pali Rohár
2017-02-21 6:42 ` H. Nikolaus Schaller
[not found] ` <4BA8DA1B-D6CB-4D38-AAD6-3B1CF217E521-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2017-02-21 8:53 ` Pali Rohár
2017-02-20 21:08 ` Pali Rohár
2017-02-20 21:27 ` H. Nikolaus Schaller
[not found] ` <C2E7AC24-75AB-442F-94A2-84904723EE41-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2017-02-20 21:50 ` Dmitry Torokhov
[not found] ` <CAKdAkRRZa-fpv_TKRdY=hFV3GdKxQ3muQORquvV_bTrDzQAhCw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-02-20 22:21 ` Petr Cvek
[not found] ` <15339314-8696-f603-d0da-beefe54f0653-qphu/3gb4gc@public.gmane.org>
2017-02-20 22:24 ` Dmitry Torokhov
2017-02-21 6:56 ` H. Nikolaus Schaller
2017-02-20 22:45 ` Pali Rohár
2017-02-21 6:36 ` H. Nikolaus Schaller
[not found] ` <0A33CCEA-448C-4C1D-9563-FDA54743BD01-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2017-02-21 9:09 ` Pali Rohár
2017-02-21 17:07 ` [Letux-kernel] " Andreas Kemnade
2017-02-20 22:04 ` Pali Rohár
2017-02-21 6:49 ` H. Nikolaus Schaller
2017-02-21 7:14 ` H. Nikolaus Schaller
[not found] ` <A41872A2-F095-47F8-B122-FFAE430B0D7F-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2017-02-21 8:47 ` Pali Rohár
2017-02-21 8:57 ` [Letux-kernel] " Christ van Willegen
[not found] ` <B30D00D0-1967-4BD5-A304-E2ADC815A805-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2017-02-21 11:07 ` Pavel Machek
2016-12-28 14:53 ` [PATCH v9 2/8] drivers:input:tsc2007: check for presence and power down tsc2007 during probe H. Nikolaus Schaller
[not found] ` <f39f47ebef2224bd73e114ee529768756bb8972a.1482936802.git.hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2017-02-17 20:52 ` Dmitry Torokhov [this message]
2016-12-28 14:53 ` [PATCH v9 3/8] DT:omap3+tsc2007: use new common touchscreen bindings H. Nikolaus Schaller
2016-12-28 14:53 ` [PATCH v9 4/8] drivers:input:ads7846(+tsc2046): add new common binding names, pre-calibration and flipping H. Nikolaus Schaller
[not found] ` <cover.1482936802.git.hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2016-12-28 14:53 ` [PATCH v9 5/8] dt-bindings: input: move ads7846 bindings to touchscreen subdirectory H. Nikolaus Schaller
2017-02-23 9:54 ` H. Nikolaus Schaller
2016-12-28 14:53 ` [PATCH v9 7/8] DT:omap3+ads7846: use new common touchscreen bindings H. Nikolaus Schaller
2017-01-16 6:34 ` [PATCH v9 0/8] drivers: touchscreen: tsc2007 and ads7846/tsc2046 improvements (use common touchscreen bindings, pre-calibration, spi fix and provide iio raw values) H. Nikolaus Schaller
[not found] ` <BB8421B2-6626-4A95-BCD0-25C4CAF30F61-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2017-01-21 13:08 ` Jonathan Cameron
[not found] ` <17d2c23b-6cbb-d365-71cb-fd4d7af7c958-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-01-21 13:17 ` H. Nikolaus Schaller
[not found] ` <B04BF50A-A54E-4CA2-BB0E-7B547D40403A-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2017-01-28 18:16 ` [Letux-kernel] " H. Nikolaus Schaller
2017-02-12 15:18 ` H. Nikolaus Schaller
[not found] ` <3225CF5D-53B7-456F-8128-50BCF31ADD0F-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2017-02-15 14:03 ` H. Nikolaus Schaller
[not found] ` <751454D6-9552-48D9-91EC-37DAD7B1A576-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2017-02-17 20:43 ` Dmitry Torokhov
2017-02-18 11:30 ` H. Nikolaus Schaller
2016-12-28 14:53 ` [PATCH v9 6/8] drivers:input:ads7846(+tsc2046): fix spi module table H. Nikolaus Schaller
[not found] ` <c79bdd79a22dab877b8a80136ac253c951698745.1482936802.git.hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2017-01-28 19:35 ` Dmitry Torokhov
2017-01-29 8:39 ` H. Nikolaus Schaller
[not found] ` <F39E49DD-45AF-4491-A26E-F3A9D86F30F6-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2017-01-29 18:01 ` Dmitry Torokhov
2017-01-29 18:25 ` H. Nikolaus Schaller
2017-02-01 20:20 ` H. Nikolaus Schaller
[not found] ` <B64DBFB0-62E8-4B4C-957F-C90C33BEF693-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2017-02-01 21:14 ` Javier Martinez Canillas
[not found] ` <cc403765-9b88-1424-a77f-36e775fbd5a0-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2017-02-01 22:28 ` Dmitry Torokhov
2017-02-01 22:50 ` Javier Martinez Canillas
2017-02-02 5:47 ` H. Nikolaus Schaller
2016-12-28 14:53 ` [PATCH v9 8/8] drivers:input:tsc2007: add iio interface to read external ADC input and temperature H. Nikolaus Schaller
[not found] ` <17a94568ffb91abedc9d12896b602022abb5f7e8.1482936802.git.hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2016-12-30 20:36 ` Jonathan Cameron
[not found] ` <230fb5c0-2603-0bd1-a8da-ce5f7c450196-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2017-02-17 21:27 ` Dmitry Torokhov
2017-02-18 11:35 ` H. Nikolaus Schaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170217205244.GG13050@dtor-ws \
--to=dmitry.torokhov-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=afd-l0cyMroinI0@public.gmane.org \
--cc=alexander.stein-93q1YBGzJSMe9JSWTWOYM3xStJ4P+DSV@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=bcousson-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \
--cc=benjamin.tissoires-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=eric-op+oiCINJLTt9jDmeYuA0g@public.gmane.org \
--cc=grinberg-UTxiZqZC01RS1MOuV/RT9w@public.gmane.org \
--cc=hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org \
--cc=javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org \
--cc=jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=mika.penttila-MRsr7dthA9VWk0Htik3J/w@public.gmane.org \
--cc=mwelling-EkmVulN54Sk@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).