From: "Pali Rohár" <pali.rohar@gmail.com>
To: John Preston <wcerfgba@riseup.net>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add model data for Dell Precision 3510 trackpad.
Date: Mon, 20 Feb 2017 16:38:54 +0100 [thread overview]
Message-ID: <20170220153854.GB20408@pali> (raw)
In-Reply-To: <76481654aedb6b687b145441283f3268@riseup.net>
On Sunday 19 February 2017 15:24:58 John Preston wrote:
> On 2017-02-19 13:35, Pali Rohár wrote:
> >On Sunday 19 February 2017 13:16:34 John L. Preston wrote:
> >>---
> >> drivers/input/mouse/alps.c | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >>diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
> >>index 328edc8c8786..c0a4edefe54d 100644
> >>--- a/drivers/input/mouse/alps.c
> >>+++ b/drivers/input/mouse/alps.c
> >>@@ -139,6 +139,7 @@ static const struct alps_model_info
> >>alps_model_data[] = {
> >> { { 0x52, 0x01, 0x14 }, 0x00, { ALPS_PROTO_V2, 0xff, 0xff,
> >> ALPS_PASS | ALPS_DUALPOINT | ALPS_PS2_INTERLEAVED } }, /* Toshiba
> >>Tecra A11-11L */
> >> { { 0x73, 0x02, 0x64 }, 0x8a, { ALPS_PROTO_V4, 0x8f, 0x8f, 0 } },
> >>+ { { 0x73, 0x03, 0x28 }, 0x13, { ALPS_PROTO_V8, 0x18, 0x18, 0 } }, /*
> >>Dell Precision 3510 */
> >> };
> >>
> >> static const struct alps_protocol_info alps_v3_protocol_data = {
> >
> >Hi John! This is not a correct place do add new proto data. I already
> >proposed reducing this table to just for PROTO_V2, but Dmitry was not
> >happy about it.
>
> Hi Pali. :)
>
> >
> >Anyway, look at function alps_identify() where is detection for ALPS_V8:
> >https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/input/mouse/alps.c?h=v4.10-rc8#n2829
> >
> >V8 is already detected when e7 is (0x73, 0x03, 0x28) and ec[1] is 0x01.
> >What are your ec data? Probably ec[1] is not 0x01 as otherwise it should
> >be already detected.
>
> I have just found that code and am confused because that is not the same
> code I have running on my system. My ec[1] is 0x01 so you are correct, it
> should already be detected and my patch is unnecessary. Sorry for the
> inconvenience.
>
> >
> >Btw, from where you got your proto data in this patch?
>
> I pulled it from dmesg:
>
> [john@slate ~]$ dmesg|grep "Unknown ALPS touchpad"
> [ 3.071891] psmouse serio1: alps: Unknown ALPS touchpad: E7=73 03 28,
> EC=73 01 13
>
So you have old kernel without support for your touchpad...
--
Pali Rohár
pali.rohar@gmail.com
prev parent reply other threads:[~2017-02-20 15:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-19 13:16 [PATCH] Add model data for Dell Precision 3510 trackpad John L. Preston
2017-02-19 13:35 ` Pali Rohár
2017-02-19 15:24 ` John Preston
2017-02-19 23:01 ` Marcos Paulo de Souza
2017-02-20 15:51 ` Unknown ALPS touchpad Pali Rohár
2017-02-21 3:10 ` Masaki Ota
2017-02-21 8:34 ` Pali Rohár
2017-02-21 11:05 ` Marcos Paulo de Souza
2017-02-20 15:38 ` Pali Rohár [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170220153854.GB20408@pali \
--to=pali.rohar@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wcerfgba@riseup.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).