From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, Jelle van der Waa <jelle@vdwaa.nl>,
Rob Herring <robh@kernel.org>,
linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: zet6223 - Export OF device ID as module aliases
Date: Mon, 20 Feb 2017 15:28:47 -0800 [thread overview]
Message-ID: <20170220232847.GA36910@dtor-ws> (raw)
In-Reply-To: <20170220200855.9951-1-javier@osg.samsung.com>
On Mon, Feb 20, 2017 at 05:08:55PM -0300, Javier Martinez Canillas wrote:
> The I2C core always reports a MODALIAS of the form i2c:<foo> even if the
> device was registered via OF, this means that exporting the OF device ID
> table device aliases in the module is not needed. But in order to change
> how the core reports modaliases to user-space, it's better to export it.
>
> Before this patch:
>
> $ modinfo drivers/input/touchscreen/zet6223.ko | grep alias
> alias: i2c:zet6223
>
> After this patch:
>
> $ modinfo drivers/input/touchscreen/zet6223.ko | grep alias
> alias: of:N*T*Czeitec,zet6223C*
> alias: of:N*T*Czeitec,zet6223
> alias: i2c:zet6223
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Applied, thank you.
> ---
>
> drivers/input/touchscreen/zet6223.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/input/touchscreen/zet6223.c b/drivers/input/touchscreen/zet6223.c
> index e7fb00b511ec..19ffcc7b886c 100644
> --- a/drivers/input/touchscreen/zet6223.c
> +++ b/drivers/input/touchscreen/zet6223.c
> @@ -245,6 +245,7 @@ static const struct of_device_id zet6223_of_match[] = {
> { .compatible = "zeitec,zet6223" },
> { }
> };
> +MODULE_DEVICE_TABLE(of, zet6223_of_match);
>
> static const struct i2c_device_id zet6223_id[] = {
> { "zet6223", 0},
> --
> 2.9.3
>
--
Dmitry
prev parent reply other threads:[~2017-02-20 23:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-20 20:08 [PATCH] Input: zet6223 - Export OF device ID as module aliases Javier Martinez Canillas
2017-02-20 23:28 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170220232847.GA36910@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=javier@osg.samsung.com \
--cc=jelle@vdwaa.nl \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).