From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH 02/14] device-dax: utilize new device_add_cdev helper function Date: Tue, 21 Feb 2017 12:37:04 +0100 Message-ID: <20170221113704.ibwkk2vuc5imkmae@piout.net> References: <1487653253-11497-1-git-send-email-logang@deltatee.com> <1487653253-11497-3-git-send-email-logang@deltatee.com> Reply-To: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Sender: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <1487653253-11497-3-git-send-email-logang-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Logan Gunthorpe Cc: Greg Kroah-Hartman , Dan Williams , Alexander Viro , Johannes Thumshirn , Jan Kara , Arnd Bergmann , Sajjan Vikas C , Dmitry Torokhov , Linus Walleij , Alexandre Courbot , Peter Huewe , Marcel Selhorst , Jarkko Sakkinen , Jason Gunthorpe , Olof Johansson , Doug Ledford , Sean Hefty , Hal Rosenstock , Dmitry Vyukov , Haggai Eran , Parav Pandit , Leon Romanovsky , Jonathan List-Id: linux-input@vger.kernel.org Hi, A small comment, you must always have a commit message. Even if it is small. On 20/02/2017 at 22:00:41 -0700, Logan Gunthorpe wrote: > Signed-off-by: Logan Gunthorpe > --- > drivers/dax/dax.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c > index ed758b7..0d24822 100644 > --- a/drivers/dax/dax.c > +++ b/drivers/dax/dax.c > @@ -701,12 +701,12 @@ struct dax_dev *devm_create_dax_dev(struct dax_region *dax_region, > > /* device_initialize() so cdev can reference kobj parent */ > device_initialize(dev); > + dev->devt = dev_t; > > cdev = &dax_dev->cdev; > cdev_init(cdev, &dax_fops); > cdev->owner = parent->driver->owner; > - cdev->kobj.parent = &dev->kobj; > - rc = cdev_add(&dax_dev->cdev, dev_t, 1); > + rc = device_add_cdev(dev, cdev); > if (rc) > goto err_cdev; > > @@ -716,7 +716,6 @@ struct dax_dev *devm_create_dax_dev(struct dax_region *dax_region, > dax_dev->region = dax_region; > kref_get(&dax_region->kref); > > - dev->devt = dev_t; > dev->class = dax_class; > dev->parent = parent; > dev->groups = dax_attribute_groups; > -- > 2.1.4 > -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.