From: Sebastian Reichel <sre@kernel.org>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Pavel Machek <pavel@ucw.cz>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Jonathan Cameron <jic23@kernel.org>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org
Subject: Re: [PATCH 3/3] Input: tsc2007 - add a property "ti,report-resistance" to restore the old pressure reporting state if needed.
Date: Tue, 21 Feb 2017 18:19:49 +0100 [thread overview]
Message-ID: <20170221171949.5nexrvezlybjbrcs@earth> (raw)
In-Reply-To: <FE6FEEC7-65B8-4C20-9C15-C641A8A8E4CA@goldelico.com>
[-- Attachment #1: Type: text/plain, Size: 860 bytes --]
Hi,
On Tue, Feb 21, 2017 at 12:43:28PM +0100, H. Nikolaus Schaller wrote:
> > Am 21.02.2017 um 12:07 schrieb Pavel Machek <pavel@ucw.cz>:
> > On Mon 2017-02-20 17:56:36, H. Nikolaus Schaller wrote:
> >> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> >
> > No. device tree is for hardware description, not kernel configuration.
>
> Yes, I agree. A new Kernel CONFIG would be better in this case.
> I just did copy&paste from the old patch set without thinking that far.
>
> Would
>
> CONFIG_TSC2007_REPORT_RAW_RESISTANCE_AS_PRESSURE
>
> be ok?
I guess either a CONFIG or a module parameter may be used to provide
the previous (broken) behaviour. I suggest to ignore the problem
until its reported, though. There is a high chance, that nobody will
notice the change at all / nobody needs the compat layer.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-02-21 17:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-20 16:56 [PATCH 0/3] Fix tsc2007 to report ABS_PRESSURE correctly H. Nikolaus Schaller
2017-02-20 16:56 ` [PATCH 1/3] Input: tsc2007 - rename function tsc2007_calculate_pressure to tsc2007_calculate_resistance because that is what it does H. Nikolaus Schaller
2017-02-23 8:45 ` Dmitry Torokhov
[not found] ` <cover.1487609795.git.hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2017-02-20 16:56 ` [PATCH 2/3] Input: tsc2007 - correctly report pressure and not resistance to user space H. Nikolaus Schaller
[not found] ` <9e249276be9e20aab1a74617373bf6587f1acd4b.1487609795.git.hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2017-02-21 17:13 ` Sebastian Reichel
2017-02-23 8:45 ` Dmitry Torokhov
2017-02-20 16:56 ` [PATCH 3/3] Input: tsc2007 - add a property "ti,report-resistance" to restore the old pressure reporting state if needed H. Nikolaus Schaller
2017-02-21 11:07 ` Pavel Machek
2017-02-21 11:43 ` H. Nikolaus Schaller
2017-02-21 17:19 ` Sebastian Reichel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170221171949.5nexrvezlybjbrcs@earth \
--to=sre@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hns@goldelico.com \
--cc=jic23@kernel.org \
--cc=letux-kernel@openphoenux.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox