linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Daniel Mack <daniel@zonque.org>
Cc: Haojian Zhuang <haojian.zhuang@gmail.com>,
	Robert Jarzmik <robert.jarzmik@free.fr>,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: [PATCH 07/10] Input: eeti_ts - use gpio_get_value_cansleep
Date: Tue, 28 Feb 2017 14:46:29 -0800	[thread overview]
Message-ID: <20170228224632.3401-7-dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <20170228224632.3401-1-dmitry.torokhov@gmail.com>

We are reading GPIO state in a non-atomic context (workqueue), so we can
use "cansleep" variant, and thus make the driver available on systems where
GPIO controllers require sleeping when reading GPIO state.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
 drivers/input/touchscreen/eeti_ts.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/touchscreen/eeti_ts.c b/drivers/input/touchscreen/eeti_ts.c
index ac78ac6d4936..fc61dbea4736 100644
--- a/drivers/input/touchscreen/eeti_ts.c
+++ b/drivers/input/touchscreen/eeti_ts.c
@@ -63,7 +63,7 @@ struct eeti_ts {
 
 static inline int eeti_ts_irq_active(struct eeti_ts *eeti)
 {
-	return gpio_get_value(eeti->irq_gpio) == eeti->irq_active_high;
+	return gpio_get_value_cansleep(eeti->irq_gpio) == eeti->irq_active_high;
 }
 
 static void eeti_ts_read(struct work_struct *work)
-- 
2.11.0.483.g087da7b7c-goog


  parent reply	other threads:[~2017-02-28 22:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-28 22:46 [PATCH 01/10] Input: eeti_ts - rename eeti_ts_priv to eeti_ts Dmitry Torokhov
2017-02-28 22:46 ` [PATCH 02/10] Input: eeti_ts - use BIT(n) Dmitry Torokhov
2017-02-28 22:46 ` [PATCH 03/10] Input: eeti_ts - use get_unaligned_be16() to retrieve data Dmitry Torokhov
2017-02-28 22:46 ` [PATCH 04/10] Input: eeti_ts - use input_set_capability() Dmitry Torokhov
2017-02-28 22:46 ` [PATCH 05/10] Input: eeti-ts - switch to using managed resources Dmitry Torokhov
2017-02-28 22:46 ` [PATCH 06/10] Input: eeti_ts - respect interrupt set in client structure Dmitry Torokhov
2017-02-28 22:46 ` Dmitry Torokhov [this message]
2017-02-28 22:46 ` [PATCH 08/10] Input: eeti_ts - switch to using threaded interrupt Dmitry Torokhov
2017-02-28 22:46 ` [PATCH 09/10] Input: eeti_ts - expect platform code to set interrupt trigger Dmitry Torokhov
2017-02-28 22:46 ` [PATCH 10/10] Input: eeti_ts - switch to gpiod API Dmitry Torokhov
2017-03-01  9:28 ` [PATCH 01/10] Input: eeti_ts - rename eeti_ts_priv to eeti_ts Daniel Mack
2017-03-01 17:34   ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170228224632.3401-7-dmitry.torokhov@gmail.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=daniel@zonque.org \
    --cc=haojian.zhuang@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robert.jarzmik@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).