From: Greg KH <gregkh@linuxfoundation.org>
To: Avraham Shukron <avraham.shukron@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
jikos@kernel.org, benjamin.tissoires@redhat.com,
linux-usb@vger.kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hid: usbhid: usbkbd: fix checkpatch.pl issues
Date: Wed, 1 Mar 2017 21:56:47 +0100 [thread overview]
Message-ID: <20170301205647.GA21651@kroah.com> (raw)
In-Reply-To: <3c67c4db-9b59-82f1-9406-3dfdb2ac0a48@gmail.com>
On Wed, Mar 01, 2017 at 09:59:31PM +0200, Avraham Shukron wrote:
> >
> > This kind of change is definitely not helpful. The original table was
> > Nx16, you converted it to Nx14. Why do you think original table used 16
> > columns?
> >
> > Regardless, it's a very old driver, just let it be.
> >
> > Thanks.
> >
>
> I can make it Nx8 :)
>
> Seriously now - I don't understand what is so wrong with checkpatch fixes?
> I'm a new to kernel development, and the natural place to start is to do some
> coding style fixes.
Start doing this in the drivers/staging/ portion of the kernel. Other
places usually do not want these types of changes for the reasons people
have given you already.
That is what drivers/staging/ is for, to learn the process. Please
stick to it there.
thanks,
greg k-h
next prev parent reply other threads:[~2017-03-01 20:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 17:26 [PATCH] hid: usbhid: usbkbd: fix checkpatch.pl issues Avraham Shukron
2017-03-01 18:16 ` Dmitry Torokhov
2017-03-01 19:59 ` Avraham Shukron
2017-03-01 20:43 ` Dmitry Torokhov
2017-03-01 20:46 ` Joe Perches
[not found] ` <1488401182.20731.11.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2017-03-01 20:55 ` Avraham Shukron
2017-03-01 20:56 ` Greg KH [this message]
2017-03-01 22:05 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170301205647.GA21651@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=avraham.shukron@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).