From: "dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>
To: Masaki Ota <masaki.ota@jp.alps.com>
Cc: Paul Donohue <linux-kernel@paulsd.com>,
Nick Fletcher <nick.m.fletcher@gmail.com>,
Joseph Salisbury <joseph.salisbury@canonical.com>,
"ben@smart-cactus.org" <ben@smart-cactus.org>,
"mhocko@suse.com" <mhocko@suse.com>,
"pali.rohar@gmail.com" <pali.rohar@gmail.com>,
"rydberg@bitmath.org" <rydberg@bitmath.org>,
"linux@roeck-us.net" <linux@roeck-us.net>,
"open list:HID CORE LAYER" <linux-input@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [REGRESSION][v4.9.y][v4.10.y] Input: ALPS - set DualPoint flag for 74 03 28 devices
Date: Tue, 7 Mar 2017 09:58:13 -0800 [thread overview]
Message-ID: <20170307175813.GC13740@dtor-ws> (raw)
In-Reply-To: <KAWPR01MB1092FD2304E3F2BC7E7C6305C72F0@KAWPR01MB1092.jpnprd01.prod.outlook.com>
Hi Masaki,
On Tue, Mar 07, 2017 at 08:40:20AM +0000, Masaki Ota wrote:
> Hi, Paul,
>
> I have modified the source code.
>
> There are three issues.
> #1. E7=73 03 28 Button pad device is not assigned "ALPS_BUTTONPAD" Flag correctly.
> #2. E7=73 03 28 devices are not assigned " ALPS_DUALPOINT" Flag correctly.
> #3. E7=73 03 28 device cursor speed is slow.
>
> Actually, the cause is all the same.
> E7=73 03 28 device does not get correct information from OTP.
> OTP is the device information byte. I specified correct bit.
>
> Then, I think it is also the issue.
> #4. Stick Pointer cursor speed is fast.
>
> I will check Stick parameter.
Could you please submit this as a proper patch now that we have
confirmation that it works? Also, I wonder if V8PLUS should be full
protocol instead of a flag.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2017-03-07 18:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 19:58 [REGRESSION][v4.9.y][v4.10.y] Input: ALPS - set DualPoint flag for 74 03 28 devices Joseph Salisbury
2017-03-04 16:15 ` Paul Donohue
[not found] ` <CAM67p+6UpxCNd23rkajZZL7Oyk1c658BEzLOXpABA0etE-A_tA@mail.gmail.com>
2017-03-05 17:56 ` Paul Donohue
2017-03-05 18:08 ` Paul Donohue
2017-03-06 8:45 ` Masaki Ota
[not found] ` <CAM67p+42U4DttN9QAF13PG2ODbRbEkEBLrARcUZRGGOd_r2SQA@mail.gmail.com>
2017-03-06 20:03 ` dmitry.torokhov
2017-03-07 2:17 ` Paul Donohue
2017-03-07 8:40 ` Masaki Ota
2017-03-07 15:51 ` Paul Donohue
2017-03-07 17:58 ` dmitry.torokhov [this message]
2017-03-08 2:36 ` Masaki Ota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170307175813.GC13740@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=ben@smart-cactus.org \
--cc=joseph.salisbury@canonical.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@paulsd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=masaki.ota@jp.alps.com \
--cc=mhocko@suse.com \
--cc=nick.m.fletcher@gmail.com \
--cc=pali.rohar@gmail.com \
--cc=rydberg@bitmath.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).