From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] Input: soc_button_array: Use NULL for GPIO connection ID Date: Thu, 9 Mar 2017 09:59:02 -0800 Message-ID: <20170309175902.GD20077@dtor-ws> References: <20170309135957.15161-1-hdegoede@redhat.com> <1489068675.20145.171.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Received: from mail-pf0-f196.google.com ([209.85.192.196]:33041 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754526AbdCISID (ORCPT ); Thu, 9 Mar 2017 13:08:03 -0500 Received: by mail-pf0-f196.google.com with SMTP id v190so8057266pfb.0 for ; Thu, 09 Mar 2017 10:08:02 -0800 (PST) Content-Disposition: inline In-Reply-To: <1489068675.20145.171.camel@linux.intel.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Andy Shevchenko Cc: Hans de Goede , linux-input@vger.kernel.org On Thu, Mar 09, 2017 at 04:11:15PM +0200, Andy Shevchenko wrote: > On Thu, 2017-03-09 at 14:59 +0100, Hans de Goede wrote: > > The gpiolib-acpi code is becoming more strict and connection-IDs > > may only be used with devices which have a _DSD with matching IDs > > in there. Since the soc_button_array ACPI binding is pure index > > based pass in NULL as connection-ID to avoid the more strict cheks > > resulting in gpiod_count and gpiod_get_index not returning any gpios. > > > > Fine by me: > > FWIW: > Reviewed-by: Andy Shevchenko Applied, thank you. > > > Cc: Andy Shevchenko > > Signed-off-by: Hans de Goede > > --- > >  drivers/input/misc/soc_button_array.c | 4 ++-- > >  1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/input/misc/soc_button_array.c > > b/drivers/input/misc/soc_button_array.c > > index eb1ba4e..b8769f6 100644 > > --- a/drivers/input/misc/soc_button_array.c > > +++ b/drivers/input/misc/soc_button_array.c > > @@ -48,7 +48,7 @@ static int soc_button_lookup_gpio(struct device > > *dev, int acpi_index) > >   struct gpio_desc *desc; > >   int gpio; > >   > > - desc = gpiod_get_index(dev, KBUILD_MODNAME, acpi_index, > > GPIOD_ASIS); > > + desc = gpiod_get_index(dev, NULL, acpi_index, GPIOD_ASIS); > >   if (IS_ERR(desc)) > >   return PTR_ERR(desc); > >   > > @@ -167,7 +167,7 @@ static int soc_button_probe(struct platform_device > > *pdev) > >   > >   button_info = (struct soc_button_info *)id->driver_data; > >   > > - if (gpiod_count(dev, KBUILD_MODNAME) <= 0) { > > + if (gpiod_count(dev, NULL) <= 0) { > >   dev_dbg(dev, "no GPIO attached, ignoring...\n"); > >   return -ENODEV; > >   } > > -- > Andy Shevchenko > Intel Finland Oy -- Dmitry