From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH v7 1/3] Input: max11801_ts: Add missing of_match_table Date: Wed, 22 Mar 2017 11:30:39 -0700 Message-ID: <20170322183039.GA2899@dtor-ws> References: <1490180808-2856-1-git-send-email-jagan@openedev.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1490180808-2856-1-git-send-email-jagan-oRp2ZoJdM/RWk0Htik3J/w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jagan Teki Cc: linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jagan Teki , Shawn Guo , Matteo Lisi , Michael Trimarchi List-Id: linux-input@vger.kernel.org On Wed, Mar 22, 2017 at 04:36:46PM +0530, Jagan Teki wrote: > From: Jagan Teki > > Added missing of_match_table for max11801_ts driver with > compatible as "maxim,max11801_ts" > Why not "maxim,max11801"? Also, I think we'd need a binding document. > Cc: Dmitry Torokhov > Cc: Shawn Guo > Cc: Matteo Lisi > Cc: Michael Trimarchi > Signed-off-by: Jagan Teki > --- > Changes for v7: > - newly added patch > > drivers/input/touchscreen/max11801_ts.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/input/touchscreen/max11801_ts.c b/drivers/input/touchscreen/max11801_ts.c > index a595ae5..5085d4f 100644 > --- a/drivers/input/touchscreen/max11801_ts.c > +++ b/drivers/input/touchscreen/max11801_ts.c > @@ -224,9 +224,16 @@ static int max11801_ts_probe(struct i2c_client *client, > }; > MODULE_DEVICE_TABLE(i2c, max11801_ts_id); > > +static const struct of_device_id max11801_ts_dt_ids[] = { > + { .compatible = "maxim,max11801_ts" }, > + { /* sentinel */ } > +}; > +MODULE_DEVICE_TABLE(of, max11801_ts_dt_ids); > + > static struct i2c_driver max11801_ts_driver = { > .driver = { > .name = "max11801_ts", > + .of_match_table = max11801_ts_dt_ids, > }, > .id_table = max11801_ts_id, > .probe = max11801_ts_probe, > -- > 1.9.1 > -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html