linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Hutterer <peter.hutterer@who-t.net>
To: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Cc: linux-input@vger.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Benjamin Tissoires <benjamin.tissoires@redhat.com>,
	Hans Verkuil <hans.verkuil@cisco.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Douglas Anderson <dianders@chromium.org>,
	Kamil Debski <kamil@wypas.org>, Ping Cheng <pinglinux@gmail.com>
Subject: Re: [PATCH RFC 1/4] input: add an EV_REL event for high-res vertical wheel
Date: Mon, 27 Mar 2017 11:40:59 +1000	[thread overview]
Message-ID: <20170327014059.GD21915@jelly> (raw)
In-Reply-To: <cf7b2e1587f2986abfa7252f9e8d2799b20911cc.1490481944.git.mchehab@s-opensource.com>

On Sat, Mar 25, 2017 at 07:49:39PM -0300, Mauro Carvalho Chehab wrote:
> As some devices can produce either low-res or high-res
> vertical wheel EV_REL events, add a new event to allow
> userspace to distinguish between them.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

Just replied to the other email, but this one is a nak until we have the
Documentation/input/event-codes.txt patch with it explaining how this code
should be used, what these codes represent, what the interaction is with
other codes (e.g. can a device send wheel and hires wheel at the same time?)
etc. There are a lot of questions left to be answered.

Cheers,
   Peter

> ---
>  include/uapi/linux/input-event-codes.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h
> index 3af60ee69053..23b2d377af59 100644
> --- a/include/uapi/linux/input-event-codes.h
> +++ b/include/uapi/linux/input-event-codes.h
> @@ -703,6 +703,7 @@
>  #define REL_DIAL		0x07
>  #define REL_WHEEL		0x08
>  #define REL_MISC		0x09
> +#define REL_HIRES_WHEEL		0x0a
>  #define REL_MAX			0x0f
>  #define REL_CNT			(REL_MAX+1)
>  
> -- 
> 2.9.3
> 
> 

      parent reply	other threads:[~2017-03-27  1:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-25 22:49 [PATCH RFC 0/4] Improve support for Logitech MX Anywhere 2 Mauro Carvalho Chehab
2017-03-25 22:49 ` [PATCH RFC 1/4] input: add an EV_REL event for high-res vertical wheel Mauro Carvalho Chehab
2017-03-25 22:49   ` [PATCH RFC 2/4] hid-logitech-hidpp: add support for high res wheel Mauro Carvalho Chehab
2017-03-25 22:49     ` [PATCH RFC 3/4] input: add a EV_SW event for ratchet switch Mauro Carvalho Chehab
2017-03-25 22:49       ` [PATCH RFC 4/4] hid-logitech-hidpp: add support " Mauro Carvalho Chehab
2017-03-27  1:53       ` [PATCH RFC 3/4] input: add a EV_SW event " Peter Hutterer
2017-03-27 12:27         ` Mauro Carvalho Chehab
2017-03-28  0:25           ` Peter Hutterer
2017-03-28  9:36             ` Mauro Carvalho Chehab
2017-03-27  1:40   ` Peter Hutterer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170327014059.GD21915@jelly \
    --to=peter.hutterer@who-t.net \
    --cc=benjamin.tissoires@redhat.com \
    --cc=dianders@chromium.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hans.verkuil@cisco.com \
    --cc=kamil@wypas.org \
    --cc=linux-input@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=mchehab@s-opensource.com \
    --cc=pinglinux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).