linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
	linux-input@vger.kernel.org, russianneuromancer@ya.ru
Subject: [PATCH] input: soc_button_array: Properly map usage-page 7 usage 0xe3 to KEY_LEFTMETA
Date: Mon, 10 Apr 2017 21:36:45 +0200	[thread overview]
Message-ID: <20170410193645.9797-1-hdegoede@redhat.com> (raw)

When submitting the support for the ACPI0011 windows tablet keys device
I mapped the "windows" logo homekey to KEY_HOMEPAGE. But this is
inconsistent with how it is done on windows tablets using the
old PNP0C40 ACPI device and it does not match the Hut spec, which says
that usage-page 7 usage 0xe3 is "Keyboard Left GUI".

This commit maps usage-page 7 usage 0xe3 to KEY_LEFTMETA fixing this.

Cc: russianneuromancer@ya.ru
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/input/misc/soc_button_array.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/misc/soc_button_array.c b/drivers/input/misc/soc_button_array.c
index d75a8a3..e1d42f1 100644
--- a/drivers/input/misc/soc_button_array.c
+++ b/drivers/input/misc/soc_button_array.c
@@ -187,7 +187,7 @@ static int soc_button_parse_btn_desc(struct device *dev,
 		info->wakeup = true;
 	} else if (upage == 0x07 && usage == 0xe3) {
 		info->name = "home";
-		info->event_code = KEY_HOMEPAGE;
+		info->event_code = KEY_LEFTMETA;
 		info->wakeup = true;
 	} else if (upage == 0x0c && usage == 0xe9) {
 		info->name = "volume_up";
-- 
2.9.3


             reply	other threads:[~2017-04-10 19:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-10 19:36 Hans de Goede [this message]
2017-04-11  3:36 ` [PATCH] input: soc_button_array: Properly map usage-page 7 usage 0xe3 to KEY_LEFTMETA Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170410193645.9797-1-hdegoede@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=russianneuromancer@ya.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).