From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH v2] input: misc: yealink: define packet offset __be16 instead of u16 Date: Mon, 10 Apr 2017 20:39:56 -0700 Message-ID: <20170411033956.GD4346@dtor-ws> References: <1491814577-26408-1-git-send-email-martin.kepplinger@ginzinger.com> <1491836422-22309-1-git-send-email-martin.kepplinger@ginzinger.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1491836422-22309-1-git-send-email-martin.kepplinger@ginzinger.com> Sender: linux-kernel-owner@vger.kernel.org To: Martin Kepplinger Cc: Henk.Vergonet@gmail.com, usbb2k-api-dev@nongnu.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-input@vger.kernel.org On Mon, Apr 10, 2017 at 05:00:22PM +0200, Martin Kepplinger wrote: > sparse says > > warning: incorrect type in assignment (different base types) > expected unsigned short [unsigned] [usertype] offset > got restricted __be16 [usertype] > > for every usage of cpu_to_be16 in yealink.c. Defining it __be16 in the > first place shouldn't hurt. > > Signed-off-by: Martin Kepplinger > Signed-off-by: Henk.Vergonet@gmail.com Applied, thank you. > --- > revision history > ---------------- > v2: add privately received Signed-off-by > > > drivers/input/misc/yealink.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/misc/yealink.h b/drivers/input/misc/yealink.h > index 1e0f523..934c247 100644 > --- a/drivers/input/misc/yealink.h > +++ b/drivers/input/misc/yealink.h > @@ -28,7 +28,7 @@ > struct yld_ctl_packet { > u8 cmd; /* command code, see below */ > u8 size; /* 1-11, size of used data bytes. */ > - u16 offset; /* internal packet offset */ > + __be16 offset; /* internal packet offset */ > u8 data[11]; > s8 sum; /* negative sum of 15 preceding bytes */ > } __attribute__ ((packed)); > -- > 2.1.4 > -- Dmitry