* [PATCH] Revert "HID: rmi: Handle all Synaptics touchpads using hid-rmi"
@ 2017-04-11 9:24 Jiri Kosina
2017-04-11 9:31 ` Benjamin Tissoires
2017-04-12 12:57 ` Jiri Kosina
0 siblings, 2 replies; 3+ messages in thread
From: Jiri Kosina @ 2017-04-11 9:24 UTC (permalink / raw)
To: Gabriele Mazzotta, aduggan, benjamin.tissoires, Dmitry Torokhov,
Peter Hutterer, Cameron Gutman, Thorsten Leemhuis, Nick Dyer,
Christopher Heiny, Jason Ekstrand
Cc: linux-kernel, linux-input
From: Jiri Kosina <jkosina@suse.cz>
This reverts commit 279967a65b320d174a507498aea7d44db3fee7f4.
Multiple regressions [1] [2] [3] have been reported. The hid-rmi
support would have to fixed and redone in 4.11+.
[1] http://lkml.kernel.org/r/b79b88c8-770a-13f6-5668-c3a94254e5e0@gmail.com
[2] http://lkml.kernel.org/r/375e67b5-2cb8-3491-1d71-d8650d6e9451@gmail.com
[3] https://bugzilla.kernel.org/show_bug.cgi?id=195287
Reported-by: Cameron Gutman <aicommander@gmail.com>
Reported-by: Gabriele Mazzotta <gabriele.mzt@gmail.com>
Reported-by: Lorenzo J. Lucchini <ljlbox@tiscali.it>
Reported-by: Thorsten Leemhuis <linux@leemhuis.info>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
drivers/hid/hid-core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index 86bbd8a1fd4a..d162f0dc76e3 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -819,8 +819,7 @@ static int hid_scan_report(struct hid_device *hid)
hid->group = HID_GROUP_WACOM;
break;
case USB_VENDOR_ID_SYNAPTICS:
- if (hid->group == HID_GROUP_GENERIC ||
- hid->group == HID_GROUP_MULTITOUCH_WIN_8)
+ if (hid->group == HID_GROUP_GENERIC)
if ((parser->scan_flags & HID_SCAN_FLAG_VENDOR_SPECIFIC)
&& (parser->scan_flags & HID_SCAN_FLAG_GD_POINTER))
/*
--
Jiri Kosina
SUSE Labs
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Revert "HID: rmi: Handle all Synaptics touchpads using hid-rmi"
2017-04-11 9:24 [PATCH] Revert "HID: rmi: Handle all Synaptics touchpads using hid-rmi" Jiri Kosina
@ 2017-04-11 9:31 ` Benjamin Tissoires
2017-04-12 12:57 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Benjamin Tissoires @ 2017-04-11 9:31 UTC (permalink / raw)
To: Jiri Kosina
Cc: Gabriele Mazzotta, aduggan, Dmitry Torokhov, Peter Hutterer,
Cameron Gutman, Thorsten Leemhuis, Nick Dyer, Christopher Heiny,
Jason Ekstrand, linux-kernel, linux-input
On Apr 11 2017 or thereabouts, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@suse.cz>
>
> This reverts commit 279967a65b320d174a507498aea7d44db3fee7f4.
>
> Multiple regressions [1] [2] [3] have been reported. The hid-rmi
> support would have to fixed and redone in 4.11+.
>
> [1] http://lkml.kernel.org/r/b79b88c8-770a-13f6-5668-c3a94254e5e0@gmail.com
> [2] http://lkml.kernel.org/r/375e67b5-2cb8-3491-1d71-d8650d6e9451@gmail.com
> [3] https://bugzilla.kernel.org/show_bug.cgi?id=195287
>
> Reported-by: Cameron Gutman <aicommander@gmail.com>
> Reported-by: Gabriele Mazzotta <gabriele.mzt@gmail.com>
> Reported-by: Lorenzo J. Lucchini <ljlbox@tiscali.it>
> Reported-by: Thorsten Leemhuis <linux@leemhuis.info>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> ---
Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cheers,
Benjamin
> drivers/hid/hid-core.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index 86bbd8a1fd4a..d162f0dc76e3 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -819,8 +819,7 @@ static int hid_scan_report(struct hid_device *hid)
> hid->group = HID_GROUP_WACOM;
> break;
> case USB_VENDOR_ID_SYNAPTICS:
> - if (hid->group == HID_GROUP_GENERIC ||
> - hid->group == HID_GROUP_MULTITOUCH_WIN_8)
> + if (hid->group == HID_GROUP_GENERIC)
> if ((parser->scan_flags & HID_SCAN_FLAG_VENDOR_SPECIFIC)
> && (parser->scan_flags & HID_SCAN_FLAG_GD_POINTER))
> /*
> --
> Jiri Kosina
> SUSE Labs
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Revert "HID: rmi: Handle all Synaptics touchpads using hid-rmi"
2017-04-11 9:24 [PATCH] Revert "HID: rmi: Handle all Synaptics touchpads using hid-rmi" Jiri Kosina
2017-04-11 9:31 ` Benjamin Tissoires
@ 2017-04-12 12:57 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2017-04-12 12:57 UTC (permalink / raw)
To: Gabriele Mazzotta, aduggan, benjamin.tissoires, Dmitry Torokhov,
Peter Hutterer, Cameron Gutman, Thorsten Leemhuis, Nick Dyer,
Christopher Heiny, Jason Ekstrand
Cc: linux-kernel, linux-input
On Tue, 11 Apr 2017, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@suse.cz>
>
> This reverts commit 279967a65b320d174a507498aea7d44db3fee7f4.
Now in Linus' tree as 84379d83d8e.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-12 12:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-11 9:24 [PATCH] Revert "HID: rmi: Handle all Synaptics touchpads using hid-rmi" Jiri Kosina
2017-04-11 9:31 ` Benjamin Tissoires
2017-04-12 12:57 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).