linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Input: elantech - add Fujitsu Lifebook E547 to force crc_enabled
@ 2017-03-09  8:19 Thorsten Leemhuis
  2017-03-09 17:50 ` ulrik.debie-os
  0 siblings, 1 reply; 8+ messages in thread
From: Thorsten Leemhuis @ 2017-03-09  8:19 UTC (permalink / raw)
  To: Dmitry Torokhov, linux-input

Temporary got a Fujitsu Lifebook E547 into my hands and noticed 
the touchpad only works after running

echo "1" > /sys/devices/platform/i8042/serio2/crc_enabled

Add it to the list of Fujitsu machines that need this workaround.

Cc: stable@vger.kernel.org
Signed-off-by: Thorsten Leemhuis <linux@leemhuis.info>
---
 drivers/input/mouse/elantech.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
index efc8ec3..c5e513b 100644
--- a/drivers/input/mouse/elantech.c
+++ b/drivers/input/mouse/elantech.c
@@ -1524,6 +1524,13 @@ static int elantech_reconnect(struct psmouse *psmouse)
 		},
 	},
 	{
+		/* Fujitsu LIFEBOOK E547  does not work with crc_enabled == 0 */
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "LIFEBOOK E547"),
+		},
+	},
+	{
 		/* Fujitsu LIFEBOOK E554  does not work with crc_enabled == 0 */
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH] Input: elantech - add Fujitsu Lifebook E547 to force crc_enabled
  2017-03-09  8:19 [PATCH] Input: elantech - add Fujitsu Lifebook E547 to force crc_enabled Thorsten Leemhuis
@ 2017-03-09 17:50 ` ulrik.debie-os
  2017-03-10  6:53   ` Thorsten Leemhuis
  0 siblings, 1 reply; 8+ messages in thread
From: ulrik.debie-os @ 2017-03-09 17:50 UTC (permalink / raw)
  To: Thorsten Leemhuis; +Cc: Dmitry Torokhov, linux-input


Thanks !

Reviewed-by: Ulrik De Bie <ulrik.debie-os@e2big.org>

Can you also provide the line equivalent for 
 * Fujitsu LIFEBOOK E554   0x570f01        40, 14, 0c      2 hw buttons
?


Kind regards,
Ulrik
On Thu, Mar 09, 2017 at 09:19:41AM +0100, Thorsten Leemhuis wrote:
> 
> Temporary got a Fujitsu Lifebook E547 into my hands and noticed 
> the touchpad only works after running
> 
> echo "1" > /sys/devices/platform/i8042/serio2/crc_enabled
> 
> Add it to the list of Fujitsu machines that need this workaround.
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Thorsten Leemhuis <linux@leemhuis.info>
> ---
>  drivers/input/mouse/elantech.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
> index efc8ec3..c5e513b 100644
> --- a/drivers/input/mouse/elantech.c
> +++ b/drivers/input/mouse/elantech.c
> @@ -1524,6 +1524,13 @@ static int elantech_reconnect(struct psmouse *psmouse)
>  		},
>  	},
>  	{
> +		/* Fujitsu LIFEBOOK E547  does not work with crc_enabled == 0 */
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "LIFEBOOK E547"),
> +		},
> +	},
> +	{
>  		/* Fujitsu LIFEBOOK E554  does not work with crc_enabled == 0 */
>  		.matches = {
>  			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
> -- 
> 1.8.3.1
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] Input: elantech - add Fujitsu Lifebook E547 to force crc_enabled
  2017-03-09 17:50 ` ulrik.debie-os
@ 2017-03-10  6:53   ` Thorsten Leemhuis
  2017-03-24 10:18     ` Thorsten Leemhuis
  0 siblings, 1 reply; 8+ messages in thread
From: Thorsten Leemhuis @ 2017-03-10  6:53 UTC (permalink / raw)
  To: ulrik.debie-os; +Cc: Dmitry Torokhov, linux-input

Lo! ulrik.debie-os@e2big.org wrote on 09.03.2017 18:50:
> 
> Can you also provide the line equivalent for 
>  * Fujitsu LIFEBOOK E554   0x570f01        40, 14, 0c      2 hw buttons
> ?

Where do I find those three values mentioned in the third column? And is
that line important at all? I just did below patch as a drive-by-patch
and from looking at the source code I can't immediately spot how to get
them :-/

FWIW, it's a 2 hw buttons touchpad and I saw this in dmesg

psmouse serio2: elantech: assuming hardware version 4 (with firmware
version )
psmouse serio2: elantech: Synaptics capabilities query result 0x50,
0x12, 0x09.
psmouse serio2: elantech: Elan sample query result 01, 27, 86

Are those values from "Elan sample query result" what you are looking
for? Then the line would be:

Fujitsu LIFEBOOK E547  0x470f00        01, 27, 86      2 hw buttons

Ciao, Thorsten


> On Thu, Mar 09, 2017 at 09:19:41AM +0100, Thorsten Leemhuis wrote:
>> 
>> Temporary got a Fujitsu Lifebook E547 into my hands and noticed 
>> the touchpad only works after running
>> 
>> echo "1" > /sys/devices/platform/i8042/serio2/crc_enabled
>> 
>> Add it to the list of Fujitsu machines that need this workaround.
>> 
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Thorsten Leemhuis <linux@leemhuis.info>
>> ---
>>  drivers/input/mouse/elantech.c | 7 +++++++
>>  1 file changed, 7 insertions(+)
>> 
>> diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
>> index efc8ec3..c5e513b 100644
>> --- a/drivers/input/mouse/elantech.c
>> +++ b/drivers/input/mouse/elantech.c
>> @@ -1524,6 +1524,13 @@ static int elantech_reconnect(struct psmouse *psmouse)
>>  		},
>>  	},
>>  	{
>> +		/* Fujitsu LIFEBOOK E547  does not work with crc_enabled == 0 */
>> +		.matches = {
>> +			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
>> +			DMI_MATCH(DMI_PRODUCT_NAME, "LIFEBOOK E547"),
>> +		},
>> +	},
>> +	{
>>  		/* Fujitsu LIFEBOOK E554  does not work with crc_enabled == 0 */
>>  		.matches = {
>>  			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
>> -- 
>> 1.8.3.1
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-input" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] Input: elantech - add Fujitsu Lifebook E547 to force crc_enabled
  2017-03-10  6:53   ` Thorsten Leemhuis
@ 2017-03-24 10:18     ` Thorsten Leemhuis
  2017-03-24 17:00       ` Dmitry Torokhov
  0 siblings, 1 reply; 8+ messages in thread
From: Thorsten Leemhuis @ 2017-03-24 10:18 UTC (permalink / raw)
  To: Dmitry Torokhov; +Cc: ulrik.debie-os, linux-input

Lo! Dmitry, did this fall through the cracks or is there any reason why
you didn't yet apply below patch? If the latter: What is needed to get
things moving? Right now I still have access to the machine for further
tests, but that will change in a week or two. Ciao, Thorsten

On 10.03.2017 07:53, Thorsten Leemhuis wrote:
> Lo! ulrik.debie-os@e2big.org wrote on 09.03.2017 18:50:
>>
>> Can you also provide the line equivalent for 
>>  * Fujitsu LIFEBOOK E554   0x570f01        40, 14, 0c      2 hw buttons
>> ?
> 
> Where do I find those three values mentioned in the third column? And is
> that line important at all? I just did below patch as a drive-by-patch
> and from looking at the source code I can't immediately spot how to get
> them :-/
> 
> FWIW, it's a 2 hw buttons touchpad and I saw this in dmesg
> 
> psmouse serio2: elantech: assuming hardware version 4 (with firmware
> version )
> psmouse serio2: elantech: Synaptics capabilities query result 0x50,
> 0x12, 0x09.
> psmouse serio2: elantech: Elan sample query result 01, 27, 86
> 
> Are those values from "Elan sample query result" what you are looking
> for? Then the line would be:
> 
> Fujitsu LIFEBOOK E547  0x470f00        01, 27, 86      2 hw buttons
> 
> Ciao, Thorsten
> 
> 
>> On Thu, Mar 09, 2017 at 09:19:41AM +0100, Thorsten Leemhuis wrote:
>>>
>>> Temporary got a Fujitsu Lifebook E547 into my hands and noticed 
>>> the touchpad only works after running
>>>
>>> echo "1" > /sys/devices/platform/i8042/serio2/crc_enabled
>>>
>>> Add it to the list of Fujitsu machines that need this workaround.
>>>
>>> Cc: stable@vger.kernel.org
>>> Signed-off-by: Thorsten Leemhuis <linux@leemhuis.info>
>>> ---
>>>  drivers/input/mouse/elantech.c | 7 +++++++
>>>  1 file changed, 7 insertions(+)
>>>
>>> diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
>>> index efc8ec3..c5e513b 100644
>>> --- a/drivers/input/mouse/elantech.c
>>> +++ b/drivers/input/mouse/elantech.c
>>> @@ -1524,6 +1524,13 @@ static int elantech_reconnect(struct psmouse *psmouse)
>>>  		},
>>>  	},
>>>  	{
>>> +		/* Fujitsu LIFEBOOK E547  does not work with crc_enabled == 0 */
>>> +		.matches = {
>>> +			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
>>> +			DMI_MATCH(DMI_PRODUCT_NAME, "LIFEBOOK E547"),
>>> +		},
>>> +	},
>>> +	{
>>>  		/* Fujitsu LIFEBOOK E554  does not work with crc_enabled == 0 */
>>>  		.matches = {
>>>  			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
>>> -- 
>>> 1.8.3.1
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-input" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] Input: elantech - add Fujitsu Lifebook E547 to force crc_enabled
  2017-03-24 10:18     ` Thorsten Leemhuis
@ 2017-03-24 17:00       ` Dmitry Torokhov
  2017-03-27  8:53         ` [PATCH v2] " Thorsten Leemhuis
  0 siblings, 1 reply; 8+ messages in thread
From: Dmitry Torokhov @ 2017-03-24 17:00 UTC (permalink / raw)
  To: Thorsten Leemhuis; +Cc: ulrik.debie-os, linux-input

Hi Thorsten,

On Fri, Mar 24, 2017 at 11:18:51AM +0100, Thorsten Leemhuis wrote:
> Lo! Dmitry, did this fall through the cracks or is there any reason why
> you didn't yet apply below patch? If the latter: What is needed to get
> things moving? Right now I still have access to the machine for further
> tests, but that will change in a week or two. Ciao, Thorsten

I was waiting for an updated version of the patch with updated info for
E547. The "caps" data is coming from Synaptics caps query, so should be
"50, 12, 09".

Thanks.

> 
> On 10.03.2017 07:53, Thorsten Leemhuis wrote:
> > Lo! ulrik.debie-os@e2big.org wrote on 09.03.2017 18:50:
> >>
> >> Can you also provide the line equivalent for 
> >>  * Fujitsu LIFEBOOK E554   0x570f01        40, 14, 0c      2 hw buttons
> >> ?
> > 
> > Where do I find those three values mentioned in the third column? And is
> > that line important at all? I just did below patch as a drive-by-patch
> > and from looking at the source code I can't immediately spot how to get
> > them :-/
> > 
> > FWIW, it's a 2 hw buttons touchpad and I saw this in dmesg
> > 
> > psmouse serio2: elantech: assuming hardware version 4 (with firmware
> > version )
> > psmouse serio2: elantech: Synaptics capabilities query result 0x50,
> > 0x12, 0x09.
> > psmouse serio2: elantech: Elan sample query result 01, 27, 86
> > 
> > Are those values from "Elan sample query result" what you are looking
> > for? Then the line would be:
> > 
> > Fujitsu LIFEBOOK E547  0x470f00        01, 27, 86      2 hw buttons
> > 
> > Ciao, Thorsten
> > 
> > 
> >> On Thu, Mar 09, 2017 at 09:19:41AM +0100, Thorsten Leemhuis wrote:
> >>>
> >>> Temporary got a Fujitsu Lifebook E547 into my hands and noticed 
> >>> the touchpad only works after running
> >>>
> >>> echo "1" > /sys/devices/platform/i8042/serio2/crc_enabled
> >>>
> >>> Add it to the list of Fujitsu machines that need this workaround.
> >>>
> >>> Cc: stable@vger.kernel.org
> >>> Signed-off-by: Thorsten Leemhuis <linux@leemhuis.info>
> >>> ---
> >>>  drivers/input/mouse/elantech.c | 7 +++++++
> >>>  1 file changed, 7 insertions(+)
> >>>
> >>> diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
> >>> index efc8ec3..c5e513b 100644
> >>> --- a/drivers/input/mouse/elantech.c
> >>> +++ b/drivers/input/mouse/elantech.c
> >>> @@ -1524,6 +1524,13 @@ static int elantech_reconnect(struct psmouse *psmouse)
> >>>  		},
> >>>  	},
> >>>  	{
> >>> +		/* Fujitsu LIFEBOOK E547  does not work with crc_enabled == 0 */
> >>> +		.matches = {
> >>> +			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
> >>> +			DMI_MATCH(DMI_PRODUCT_NAME, "LIFEBOOK E547"),
> >>> +		},
> >>> +	},
> >>> +	{
> >>>  		/* Fujitsu LIFEBOOK E554  does not work with crc_enabled == 0 */
> >>>  		.matches = {
> >>>  			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
> >>> -- 
> >>> 1.8.3.1
> >>> --
> >>> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> >>> the body of a message to majordomo@vger.kernel.org
> >>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >>

-- 
Dmitry

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH v2] Input: elantech - add Fujitsu Lifebook E547 to force crc_enabled
  2017-03-24 17:00       ` Dmitry Torokhov
@ 2017-03-27  8:53         ` Thorsten Leemhuis
  2017-04-18 13:42           ` Thorsten Leemhuis
  0 siblings, 1 reply; 8+ messages in thread
From: Thorsten Leemhuis @ 2017-03-27  8:53 UTC (permalink / raw)
  To: Dmitry Torokhov; +Cc: ulrik.debie-os, linux-input

Hi! On 24.03.2017 18:00, Dmitry Torokhov wrote: 
> On Fri, Mar 24, 2017 at 11:18:51AM +0100, Thorsten Leemhuis wrote:
>> Lo! Dmitry, did this fall through the cracks or is there any reason why
>> you didn't yet apply below patch? If the latter: What is needed to get
>> things moving? Right now I still have access to the machine for further
>> tests, but that will change in a week or two. Ciao, Thorsten
> I was waiting for an updated version of the patch with updated info for
> E547. The "caps" data is coming from Synaptics caps query, so should be
> "50, 12, 09".

/me opens eyes properly and reads the output from dmesg again
/me wonders why he hadn't noticed the capabilities output from the
synaptics driver before and missed the obvious connection

Many thx for the pointer! Find an updated patch below.

Ciao, Thorsten

>From 8feadc9af68c77c9e0fec3f85b9d5312b8f2e468 Mon Sep 17 00:00:00 2001
From: Thorsten Leemhuis <linux@leemhuis.info>
Date: Thu, 9 Mar 2017 08:13:21 +0100
Subject: Input: elantech - add Fujitsu Lifebook E547 to force crc_enabled

Temprary got a Lifebook E547 into my hands and noticed the touchpad
only works after running

echo "1" > /sys/devices/platform/i8042/serio2/crc_enabled

Add it to the list of machines that need this workaround.

Cc: stable@vger.kernel.org
Signed-off-by: Thorsten Leemhuis <linux@leemhuis.info>
Reviewed-by: Ulrik De Bie <ulrik.debie-os@e2big.org>
---
 drivers/input/mouse/elantech.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
index efc8ec3..f53dad0 100644
--- a/drivers/input/mouse/elantech.c
+++ b/drivers/input/mouse/elantech.c
@@ -1118,6 +1118,7 @@ static int elantech_get_resolution_v4(struct psmouse *psmouse,
  * Asus UX32VD             0x361f02        00, 15, 0e      clickpad
  * Avatar AVIU-145A2       0x361f00        ?               clickpad
  * Fujitsu LIFEBOOK E544   0x470f00        d0, 12, 09      2 hw buttons
+ * Fujitsu LIFEBOOK E547   0x470f00        50, 12, 09      2 hw buttons
  * Fujitsu LIFEBOOK E554   0x570f01        40, 14, 0c      2 hw buttons
  * Fujitsu T725            0x470f01        05, 12, 09      2 hw buttons
  * Fujitsu H730            0x570f00        c0, 14, 0c      3 hw buttons (**)
@@ -1524,6 +1525,13 @@ static int elantech_reconnect(struct psmouse *psmouse)
 		},
 	},
 	{
+		/* Fujitsu LIFEBOOK E547  does not work with crc_enabled == 0 */
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "LIFEBOOK E547"),
+		},
+	},
+	{
 		/* Fujitsu LIFEBOOK E554  does not work with crc_enabled == 0 */
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
-- 
1.8.3.1



^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH v2] Input: elantech - add Fujitsu Lifebook E547 to force crc_enabled
  2017-03-27  8:53         ` [PATCH v2] " Thorsten Leemhuis
@ 2017-04-18 13:42           ` Thorsten Leemhuis
  2017-04-18 18:16             ` Dmitry Torokhov
  0 siblings, 1 reply; 8+ messages in thread
From: Thorsten Leemhuis @ 2017-04-18 13:42 UTC (permalink / raw)
  To: Dmitry Torokhov; +Cc: ulrik.debie-os, linux-input

Lo! Dmitry, did this fall through the cracks or is there any reason why
you didn't yet apply below patch? If the latter: What is needed to get
things moving? Ciao, Thorsten

On 27.03.2017 10:53, Thorsten Leemhuis wrote:
> Hi! On 24.03.2017 18:00, Dmitry Torokhov wrote: 
>> On Fri, Mar 24, 2017 at 11:18:51AM +0100, Thorsten Leemhuis wrote:
>>> Lo! Dmitry, did this fall through the cracks or is there any reason why
>>> you didn't yet apply below patch? If the latter: What is needed to get
>>> things moving? Right now I still have access to the machine for further
>>> tests, but that will change in a week or two. Ciao, Thorsten
>> I was waiting for an updated version of the patch with updated info for
>> E547. The "caps" data is coming from Synaptics caps query, so should be
>> "50, 12, 09".
> 
> /me opens eyes properly and reads the output from dmesg again
> /me wonders why he hadn't noticed the capabilities output from the
> synaptics driver before and missed the obvious connection
> 
> Many thx for the pointer! Find an updated patch below.
> 
> Ciao, Thorsten
> 
> From 8feadc9af68c77c9e0fec3f85b9d5312b8f2e468 Mon Sep 17 00:00:00 2001
> From: Thorsten Leemhuis <linux@leemhuis.info>
> Date: Thu, 9 Mar 2017 08:13:21 +0100
> Subject: Input: elantech - add Fujitsu Lifebook E547 to force crc_enabled
> 
> Temprary got a Lifebook E547 into my hands and noticed the touchpad
> only works after running
> 
> echo "1" > /sys/devices/platform/i8042/serio2/crc_enabled
> 
> Add it to the list of machines that need this workaround.
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Thorsten Leemhuis <linux@leemhuis.info>
> Reviewed-by: Ulrik De Bie <ulrik.debie-os@e2big.org>
> ---
>  drivers/input/mouse/elantech.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
> index efc8ec3..f53dad0 100644
> --- a/drivers/input/mouse/elantech.c
> +++ b/drivers/input/mouse/elantech.c
> @@ -1118,6 +1118,7 @@ static int elantech_get_resolution_v4(struct psmouse *psmouse,
>   * Asus UX32VD             0x361f02        00, 15, 0e      clickpad
>   * Avatar AVIU-145A2       0x361f00        ?               clickpad
>   * Fujitsu LIFEBOOK E544   0x470f00        d0, 12, 09      2 hw buttons
> + * Fujitsu LIFEBOOK E547   0x470f00        50, 12, 09      2 hw buttons
>   * Fujitsu LIFEBOOK E554   0x570f01        40, 14, 0c      2 hw buttons
>   * Fujitsu T725            0x470f01        05, 12, 09      2 hw buttons
>   * Fujitsu H730            0x570f00        c0, 14, 0c      3 hw buttons (**)
> @@ -1524,6 +1525,13 @@ static int elantech_reconnect(struct psmouse *psmouse)
>  		},
>  	},
>  	{
> +		/* Fujitsu LIFEBOOK E547  does not work with crc_enabled == 0 */
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "LIFEBOOK E547"),
> +		},
> +	},
> +	{
>  		/* Fujitsu LIFEBOOK E554  does not work with crc_enabled == 0 */
>  		.matches = {
>  			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH v2] Input: elantech - add Fujitsu Lifebook E547 to force crc_enabled
  2017-04-18 13:42           ` Thorsten Leemhuis
@ 2017-04-18 18:16             ` Dmitry Torokhov
  0 siblings, 0 replies; 8+ messages in thread
From: Dmitry Torokhov @ 2017-04-18 18:16 UTC (permalink / raw)
  To: Thorsten Leemhuis; +Cc: ulrik.debie-os, linux-input

On Tue, Apr 18, 2017 at 03:42:55PM +0200, Thorsten Leemhuis wrote:
> Lo! Dmitry, did this fall through the cracks or is there any reason why
> you didn't yet apply below patch? If the latter: What is needed to get
> things moving? Ciao, Thorsten

Sorry, v2 got lost in the thread. Applied now.

> 
> On 27.03.2017 10:53, Thorsten Leemhuis wrote:
> > Hi! On 24.03.2017 18:00, Dmitry Torokhov wrote: 
> >> On Fri, Mar 24, 2017 at 11:18:51AM +0100, Thorsten Leemhuis wrote:
> >>> Lo! Dmitry, did this fall through the cracks or is there any reason why
> >>> you didn't yet apply below patch? If the latter: What is needed to get
> >>> things moving? Right now I still have access to the machine for further
> >>> tests, but that will change in a week or two. Ciao, Thorsten
> >> I was waiting for an updated version of the patch with updated info for
> >> E547. The "caps" data is coming from Synaptics caps query, so should be
> >> "50, 12, 09".
> > 
> > /me opens eyes properly and reads the output from dmesg again
> > /me wonders why he hadn't noticed the capabilities output from the
> > synaptics driver before and missed the obvious connection
> > 
> > Many thx for the pointer! Find an updated patch below.
> > 
> > Ciao, Thorsten
> > 
> > From 8feadc9af68c77c9e0fec3f85b9d5312b8f2e468 Mon Sep 17 00:00:00 2001
> > From: Thorsten Leemhuis <linux@leemhuis.info>
> > Date: Thu, 9 Mar 2017 08:13:21 +0100
> > Subject: Input: elantech - add Fujitsu Lifebook E547 to force crc_enabled
> > 
> > Temprary got a Lifebook E547 into my hands and noticed the touchpad
> > only works after running
> > 
> > echo "1" > /sys/devices/platform/i8042/serio2/crc_enabled
> > 
> > Add it to the list of machines that need this workaround.
> > 
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Thorsten Leemhuis <linux@leemhuis.info>
> > Reviewed-by: Ulrik De Bie <ulrik.debie-os@e2big.org>
> > ---
> >  drivers/input/mouse/elantech.c | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
> > index efc8ec3..f53dad0 100644
> > --- a/drivers/input/mouse/elantech.c
> > +++ b/drivers/input/mouse/elantech.c
> > @@ -1118,6 +1118,7 @@ static int elantech_get_resolution_v4(struct psmouse *psmouse,
> >   * Asus UX32VD             0x361f02        00, 15, 0e      clickpad
> >   * Avatar AVIU-145A2       0x361f00        ?               clickpad
> >   * Fujitsu LIFEBOOK E544   0x470f00        d0, 12, 09      2 hw buttons
> > + * Fujitsu LIFEBOOK E547   0x470f00        50, 12, 09      2 hw buttons
> >   * Fujitsu LIFEBOOK E554   0x570f01        40, 14, 0c      2 hw buttons
> >   * Fujitsu T725            0x470f01        05, 12, 09      2 hw buttons
> >   * Fujitsu H730            0x570f00        c0, 14, 0c      3 hw buttons (**)
> > @@ -1524,6 +1525,13 @@ static int elantech_reconnect(struct psmouse *psmouse)
> >  		},
> >  	},
> >  	{
> > +		/* Fujitsu LIFEBOOK E547  does not work with crc_enabled == 0 */
> > +		.matches = {
> > +			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
> > +			DMI_MATCH(DMI_PRODUCT_NAME, "LIFEBOOK E547"),
> > +		},
> > +	},
> > +	{
> >  		/* Fujitsu LIFEBOOK E554  does not work with crc_enabled == 0 */
> >  		.matches = {
> >  			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
> > 

-- 
Dmitry

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2017-04-18 18:16 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-09  8:19 [PATCH] Input: elantech - add Fujitsu Lifebook E547 to force crc_enabled Thorsten Leemhuis
2017-03-09 17:50 ` ulrik.debie-os
2017-03-10  6:53   ` Thorsten Leemhuis
2017-03-24 10:18     ` Thorsten Leemhuis
2017-03-24 17:00       ` Dmitry Torokhov
2017-03-27  8:53         ` [PATCH v2] " Thorsten Leemhuis
2017-04-18 13:42           ` Thorsten Leemhuis
2017-04-18 18:16             ` Dmitry Torokhov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).