From: Jean Delvare <jdelvare@suse.de>
To: linux-input@vger.kernel.org
Cc: Jaechul Lee <jcsing.lee@samsung.com>,
Beomho Seo <beomho.seo@samsung.com>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Andi Shyti <andi.shyti@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Rob Herring <robh@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: [RFC PATCH] Input: tm2-touchkey - add hardware dependency
Date: Mon, 24 Apr 2017 09:42:31 +0200 [thread overview]
Message-ID: <20170424094231.435f82de@endymion> (raw)
The tm2-touchkey driver is only useful on specific platforms. Add the
missing hardware dependency so that the driver is not proposed on
systems where the device does not exist.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Fixes: 72d1f2346ded ("Input: tm2-touchkey - add touchkey driver support for TM2")
Cc: Jaechul Lee <jcsing.lee@samsung.com>
Cc: Beomho Seo <beomho.seo@samsung.com>
Cc: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: Andi Shyti <andi.shyti@samsung.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Rob Herring <robh@kernel.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
Note: I am not familar with the hardware in question so I'm not sure
if this is the right dependency to add, or if ARM64 would be more
appropriate, or something else, or a combination thereof. Please
advise.
drivers/input/keyboard/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- linux-4.11-rc8.orig/drivers/input/keyboard/Kconfig 2017-04-03 02:23:54.000000000 +0200
+++ linux-4.11-rc8/drivers/input/keyboard/Kconfig 2017-04-24 09:26:43.314252700 +0200
@@ -670,6 +670,7 @@ config KEYBOARD_TM2_TOUCHKEY
tristate "TM2 touchkey support"
depends on I2C
depends on LEDS_CLASS
+ depends on ARCH_EXYNOS || COMPILE_TEST
help
Say Y here to enable device driver for tm2-touchkey with
LED control for the Exynos5433 TM2 board.
--
Jean Delvare
SUSE L3 Support
next reply other threads:[~2017-04-24 7:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170424074240epcas3p2f90e0507afab25e9bfa48fe564936198@epcas3p2.samsung.com>
2017-04-24 7:42 ` Jean Delvare [this message]
2017-04-24 8:00 ` [RFC PATCH] Input: tm2-touchkey - add hardware dependency Krzysztof Kozlowski
2017-04-24 9:48 ` Jean Delvare
2017-04-24 9:58 ` Krzysztof Kozlowski
2017-04-24 11:34 ` Jean Delvare
2017-04-24 11:56 ` Krzysztof Kozlowski
2017-04-24 17:09 ` Dmitry Torokhov
2017-04-24 18:31 ` Krzysztof Kozlowski
2017-04-25 8:58 ` Jean Delvare
2017-04-24 18:49 ` Jean Delvare
2017-04-24 18:57 ` Krzysztof Kozlowski
2017-04-25 9:37 ` Jean Delvare
2017-04-25 2:28 ` Andi Shyti
2017-04-25 9:55 ` Jean Delvare
2017-04-25 11:00 ` Andi Shyti
2017-04-25 17:28 ` Dmitry Torokhov
2017-05-03 9:42 ` Jean Delvare
2017-05-03 9:53 ` Krzysztof Kozlowski
2017-05-03 8:31 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170424094231.435f82de@endymion \
--to=jdelvare@suse.de \
--cc=andi.shyti@samsung.com \
--cc=beomho.seo@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=dmitry.torokhov@gmail.com \
--cc=javier@osg.samsung.com \
--cc=jcsing.lee@samsung.com \
--cc=krzk@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).