From: "Bruno Prémont" <bonbons@linux-vserver.org>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-iio@vger.kernel.org, linux-input@vger.kernel.org,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Henrik Rydberg <rydberg@bitmath.org>,
Jiri Kosina <jikos@kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 7/7] HID: picoLCD: Replace two seq_printf() calls by seq_puts() in picolcd_debug_reset_show()
Date: Tue, 25 Apr 2017 08:40:51 +0200 [thread overview]
Message-ID: <20170425084051.5b981b48@pluto.restena.lu> (raw)
In-Reply-To: <ceee0ae6-fd37-66b6-116a-319f5e393327@users.sourceforge.net>
Acked-by: Bruno Prémont <bonbons@linux-vserver.org>
On Mon, 24 Apr 2017 22:23:02 +0200 SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Mon, 24 Apr 2017 21:27:42 +0200
>
> Strings which did not contain data format specifications should be put
> into a sequence. Thus use the corresponding function "seq_puts".
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/hid/hid-picolcd_debugfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hid/hid-picolcd_debugfs.c b/drivers/hid/hid-picolcd_debugfs.c
> index 3e0feb4bb538..975f36601d59 100644
> --- a/drivers/hid/hid-picolcd_debugfs.c
> +++ b/drivers/hid/hid-picolcd_debugfs.c
> @@ -33,9 +33,9 @@
> static int picolcd_debug_reset_show(struct seq_file *f, void *p)
> {
> if (picolcd_fbinfo((struct picolcd_data *)f->private))
> - seq_printf(f, "all fb\n");
> + seq_puts(f, "all fb\n");
> else
> - seq_printf(f, "all\n");
> + seq_puts(f, "all\n");
> return 0;
> }
>
next prev parent reply other threads:[~2017-04-25 6:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 20:12 [PATCH 0/7] HID: Fine-tuning for some function implementations SF Markus Elfring
[not found] ` <2d526d72-a740-367b-04a9-ed698435f8ed-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
2017-04-24 20:16 ` [PATCH 1/7] HID: sensor-hub: Use devm_kcalloc() in sensor_hub_probe() SF Markus Elfring
2017-04-24 20:17 ` [PATCH 2/7] HID: sensor-hub: Delete error messages for failed memory allocations " SF Markus Elfring
2017-04-27 18:16 ` SF Markus Elfring
2017-04-24 20:18 ` [PATCH 3/7] HID: sensor-hub: Adjust two checks for null pointers " SF Markus Elfring
2017-04-24 20:22 ` [PATCH 6/7] HID: debug: Combine two seq_printf() calls into one call in hid_dump_device() SF Markus Elfring
2017-04-24 20:23 ` [PATCH 7/7] HID: picoLCD: Replace two seq_printf() calls by seq_puts() in picolcd_debug_reset_show() SF Markus Elfring
2017-04-25 6:40 ` Bruno Prémont [this message]
2017-04-24 20:20 ` [PATCH 4/7] HID: debug: Replace five seq_printf() calls by seq_putc() SF Markus Elfring
2017-04-24 20:21 ` [PATCH 5/7] HID: debug: Replace 12 seq_printf() calls by seq_puts() SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170425084051.5b981b48@pluto.restena.lu \
--to=bonbons@linux-vserver.org \
--cc=benjamin.tissoires@redhat.com \
--cc=elfring@users.sourceforge.net \
--cc=jic23@kernel.org \
--cc=jikos@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@bitmath.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).