From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: Marek Vasut <marex@denx.de>, Lee Jones <lee.jones@linaro.org>,
Ksenija Stanojevic <ksenija.stanojevic@gmail.com>,
Wei Yongjun <weiyongjun1@huawei.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH -next] input: touchscreen: mxs-lradc: Make symbol mxs_lradc_ts_irq_names static
Date: Tue, 25 Apr 2017 10:05:32 -0700 [thread overview]
Message-ID: <20170425170532.GA30843@dtor-ws> (raw)
In-Reply-To: <20170425062704.26222-1-weiyj.lk@gmail.com>
On Tue, Apr 25, 2017 at 06:27:04AM +0000, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fixes the following sparse warning:
>
> drivers/input/touchscreen/mxs-lradc-ts.c:33:12: warning:
> symbol 'mxs_lradc_ts_irq_names' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/input/touchscreen/mxs-lradc-ts.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/mxs-lradc-ts.c b/drivers/input/touchscreen/mxs-lradc-ts.c
> index 4b4aebf..603ac5a 100644
> --- a/drivers/input/touchscreen/mxs-lradc-ts.c
> +++ b/drivers/input/touchscreen/mxs-lradc-ts.c
> @@ -30,7 +30,7 @@
> #include <linux/of_irq.h>
> #include <linux/platform_device.h>
>
> -const char *mxs_lradc_ts_irq_names[] = {
> +static const char *mxs_lradc_ts_irq_names[] = {
FWIW checkpatch recommends "static const char * const".
> "mxs-lradc-touchscreen",
> "mxs-lradc-channel6",
> "mxs-lradc-channel7",
>
--
Dmitry
prev parent reply other threads:[~2017-04-25 17:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 6:27 [PATCH -next] input: touchscreen: mxs-lradc: Make symbol mxs_lradc_ts_irq_names static Wei Yongjun
2017-04-25 17:05 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170425170532.GA30843@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=ksenija.stanojevic@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=marex@denx.de \
--cc=weiyj.lk@gmail.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).