From mboxrd@z Thu Jan 1 00:00:00 1970 From: ulrik.debie-os@e2big.org Subject: Re: Input: mouse: Trackpoint middle button not recognized on Thinkpad E470 Date: Tue, 25 Apr 2017 23:16:33 +0200 Message-ID: <20170425211633.bl72ajw5duwdpq4j@beacon.debie> References: <13710506-2225-9f81-40e3-7463ac829860@techfak.uni-bielefeld.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from e2big.org ([198.61.226.133]:45860 "EHLO e2big.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2993790AbdDYVen (ORCPT ); Tue, 25 Apr 2017 17:34:43 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov , Julian Exner Cc: "linux-input@vger.kernel.org" , aduggan@synaptics.com Hi Julian, Dmitry, I have a similar behaviour for thinkpad e570 trackpoint. Manually forcing button_info also made the middle button work. Julian, I planned to go the investigation road just when I happened to see your email. Dmitry, what do you suggest as a path forward when extended-button-data command fails ? Check for DMI and whitelist 3button for certain laptops which will be a growing list (2 laptops known already)? Default to 3 buttons when extended-button-data command fails ? Julian, feel free to propose a patch, I'll review and test on E570. Kind regards, Ulrik On Tue, Apr 25, 2017 at 10:06:56PM +0200, Julian Exner wrote: > Date: Tue, 25 Apr 2017 22:06:56 +0200 > From: Julian Exner > To: "linux-input@vger.kernel.org" > Cc: aduggan@synaptics.com > Subject: Re: Input: mouse: Trackpoint middle button not recognized on > Thinkpad E470 > X-Mailing-List: linux-input@vger.kernel.org > > I checked the Trackpoint specification [1] and apparently 0xFE stands for > the Trackpoint controller asking to resend the command due to invalid input. > Resending the extended-button-data command results in 0xFC which stands for > another invalid input. But 0xFE does not only stand for a resend request but > might also mean that the issued command is not implemented in the ROM. [2] > > So maybe when the extended-button-data command is not support, we can check > for certain Trackpoint or ROM ids to deduce if a middle button is present. > If you think this is the right approach I may craft a patch for this. > > [1] http://blogs.epfl.ch/icenet/documents/Ykt3Eext.pdf > [2] http://blogs.epfl.ch/icenet/documents/Ykt3Eext.pdf#page=20 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-input" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html