From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: linux-input@vger.kernel.org
Cc: Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>
Subject: [PATCH] HID: Support i2c-hid multitouch compatible Wacom touchscreens
Date: Thu, 27 Apr 2017 16:57:57 +0300 [thread overview]
Message-ID: <20170427135757.29947-1-jarkko.nikula@linux.intel.com> (raw)
Vendor specific handling in hid_scan_report() overrides the hid->group
to HID_GROUP_WACOM for all devices with vendor ID equal to
USB_VENDOR_ID_WACOM.
However there is an i2c-hid multitouch compatible Wacom touschreen which
is parsed as generic HID_GROUP_MULTITOUCH_WIN_8 device but
hid-multitouch doesn't probe because of this overriding.
Support this touschreen by overring the group only when the bus is
different than I2C.
Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
---
I'm not an HID expert and I don't know is there any existing Wacom
tablets using the I2C bus. There are USB and Bluetooth tablets so that's
the reason I'm checking id->bus != BUS_I2C when overring the group.
I've done only basic testing that device is registered as an
hid-multitouch device and "hexdump /dev/input/eventX" produces a bunch
of hexadecimals when touschscreen is touched.
---
drivers/hid/hid-core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
index d162f0dc76e3..cfb0b7262de7 100644
--- a/drivers/hid/hid-core.c
+++ b/drivers/hid/hid-core.c
@@ -816,7 +816,8 @@ static int hid_scan_report(struct hid_device *hid)
*/
switch (hid->vendor) {
case USB_VENDOR_ID_WACOM:
- hid->group = HID_GROUP_WACOM;
+ if (hid->bus != BUS_I2C)
+ hid->group = HID_GROUP_WACOM;
break;
case USB_VENDOR_ID_SYNAPTICS:
if (hid->group == HID_GROUP_GENERIC)
--
2.11.0
next reply other threads:[~2017-04-27 14:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 13:57 Jarkko Nikula [this message]
2017-04-27 15:09 ` [PATCH] HID: Support i2c-hid multitouch compatible Wacom touchscreens Benjamin Tissoires
2017-04-27 22:48 ` Jason Gerecke
2017-04-28 6:59 ` Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170427135757.29947-1-jarkko.nikula@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).