From: Tony Lindgren <tony@atomide.com>
To: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Cc: Sebastian Reichel <sre@kernel.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-input@vger.kernel.org, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 1/2] Input: pwm-vibra: new driver
Date: Wed, 3 May 2017 17:39:52 -0700 [thread overview]
Message-ID: <20170504003952.GN3780@atomide.com> (raw)
In-Reply-To: <20170503111128.15385-2-sebastian.reichel@collabora.co.uk>
* Sebastian Reichel <sebastian.reichel@collabora.co.uk> [170503 04:14]:
> Provide a simple driver for PWM controllable vibrators. It
> will be used by Motorola Droid 4.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
> ---
> Changes since PATCHv1:
> - move driver removal code to input->close function
> - mark PM functions __maybe_unused and drop #ifdef CONFIG_PM_SLEEP
> - remove duplicate NULL check for vibrator in probe function
> - cancel work in suspend function
I'm getting this if CONFIG_INPUT_FF_MEMLESS is not selected:
ERROR: "input_ff_create_memless" [drivers/input/misc/pwm-vibra.ko] undefined!
Other than that works for me with your test app after
modprobe of pwm-omap-dmtimer and ff_memless:
Tested-by: Tony Lindgren <tony@atomide.com>
next prev parent reply other threads:[~2017-05-04 0:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-03 11:11 [PATCHv2 0/2] PWM Vibrator driver Sebastian Reichel
[not found] ` <20170503111128.15385-1-sebastian.reichel-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2017-05-03 11:11 ` [PATCHv2 1/2] Input: pwm-vibra: new driver Sebastian Reichel
2017-05-04 0:39 ` Tony Lindgren [this message]
2017-05-03 11:11 ` [PATCHv2 2/2] ARM: dts: omap4-droid4: Add vibrator Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170504003952.GN3780@atomide.com \
--to=tony@atomide.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.co.uk \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).