From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Subject: Re: [PATCH] Input: synaptics-rmi4 - change a char type to u8
Date: Mon, 29 May 2017 20:21:43 -0700
Message-ID: <20170530032143.GG32841@dtor-ws>
References: <20170503212319.frj4k66dzezlleey@mwanda>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <linux-input-owner@vger.kernel.org>
Received: from mail-pf0-f195.google.com ([209.85.192.195]:35723 "EHLO
        mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750811AbdE3DVq (ORCPT
        <rfc822;linux-input@vger.kernel.org>);
        Mon, 29 May 2017 23:21:46 -0400
Content-Disposition: inline
In-Reply-To: <20170503212319.frj4k66dzezlleey@mwanda>
Sender: linux-input-owner@vger.kernel.org
List-Id: linux-input@vger.kernel.org
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Nick Dyer <nick@shmanahar.org>, Benjamin Tissoires <benjamin.tissoires@redhat.com>, linux-input@vger.kernel.org, kernel-janitors@vger.kernel.org

On Thu, May 04, 2017 at 12:23:19AM +0300, Dan Carpenter wrote:
> Smatch doesn't like when we use "%02X" to print char types because,
> what about if it's a negative?

Applied, thank you. Furthermore, I think we could reduce it to using %ph
instead of that loop.

> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/input/rmi4/rmi_f34v7.c b/drivers/input/rmi4/rmi_f34v7.c
> index 10c0d11b72c9..ae2db1c3aebf 100644
> --- a/drivers/input/rmi4/rmi_f34v7.c
> +++ b/drivers/input/rmi4/rmi_f34v7.c
> @@ -518,7 +518,7 @@ static int rmi_f34v7_read_queries(struct f34_data *f34)
>  			query_1_7.partition_support[1] & HAS_GUEST_CODE;
>  
>  	if (query_0 & HAS_CONFIG_ID) {
> -		char f34_ctrl[CONFIG_ID_SIZE];
> +		u8 f34_ctrl[CONFIG_ID_SIZE];
>  		int i = 0;
>  		u8 *p = f34->configuration_id;
>  		*p = '\0';

Thanks.

-- 
Dmitry