From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Carlo Caione <carlo@caione.org>
Cc: jikos@kernel.org, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, linux@endlessm.com,
Carlo Caione <carlo@endlessm.com>
Subject: Re: [PATCH] HID: asus: Stop underlying hardware on remove
Date: Fri, 2 Jun 2017 09:31:00 +0200 [thread overview]
Message-ID: <20170602073100.GL1293@mail.corp.redhat.com> (raw)
In-Reply-To: <20170530203946.9346-1-carlo@caione.org>
On May 30 2017 or thereabouts, Carlo Caione wrote:
> From: Carlo Caione <carlo@endlessm.com>
>
> We are missing a call to hid_hw_stop() on the remove hook.
> Among other things this is causing an Oops when (re-)starting GNOME /
> upowerd / ... after the module has been already rmmod-ed.
Good catch:
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cheers,
Benjamin
>
> Signed-off-by: Carlo Caione <carlo@endlessm.com>
> ---
> drivers/hid/hid-asus.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
> index 16df6cc..2e9642d 100644
> --- a/drivers/hid/hid-asus.c
> +++ b/drivers/hid/hid-asus.c
> @@ -536,6 +536,8 @@ static void asus_remove(struct hid_device *hdev)
> drvdata->kbd_backlight->removed = true;
> cancel_work_sync(&drvdata->kbd_backlight->work);
> }
> +
> + hid_hw_stop(hdev);
> }
>
> static __u8 *asus_report_fixup(struct hid_device *hdev, __u8 *rdesc,
> --
> 2.9.3
>
next prev parent reply other threads:[~2017-06-02 7:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-30 20:39 [PATCH] HID: asus: Stop underlying hardware on remove Carlo Caione
2017-06-02 7:31 ` Benjamin Tissoires [this message]
2017-06-02 12:14 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170602073100.GL1293@mail.corp.redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=carlo@caione.org \
--cc=carlo@endlessm.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@endlessm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).