* [PATCH] HID: asus: Stop underlying hardware on remove
@ 2017-05-30 20:39 Carlo Caione
2017-06-02 7:31 ` Benjamin Tissoires
2017-06-02 12:14 ` Jiri Kosina
0 siblings, 2 replies; 3+ messages in thread
From: Carlo Caione @ 2017-05-30 20:39 UTC (permalink / raw)
To: jikos, benjamin.tissoires, linux-input, linux-kernel, linux; +Cc: Carlo Caione
From: Carlo Caione <carlo@endlessm.com>
We are missing a call to hid_hw_stop() on the remove hook.
Among other things this is causing an Oops when (re-)starting GNOME /
upowerd / ... after the module has been already rmmod-ed.
Signed-off-by: Carlo Caione <carlo@endlessm.com>
---
drivers/hid/hid-asus.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
index 16df6cc..2e9642d 100644
--- a/drivers/hid/hid-asus.c
+++ b/drivers/hid/hid-asus.c
@@ -536,6 +536,8 @@ static void asus_remove(struct hid_device *hdev)
drvdata->kbd_backlight->removed = true;
cancel_work_sync(&drvdata->kbd_backlight->work);
}
+
+ hid_hw_stop(hdev);
}
static __u8 *asus_report_fixup(struct hid_device *hdev, __u8 *rdesc,
--
2.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] HID: asus: Stop underlying hardware on remove
2017-05-30 20:39 [PATCH] HID: asus: Stop underlying hardware on remove Carlo Caione
@ 2017-06-02 7:31 ` Benjamin Tissoires
2017-06-02 12:14 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Benjamin Tissoires @ 2017-06-02 7:31 UTC (permalink / raw)
To: Carlo Caione; +Cc: jikos, linux-input, linux-kernel, linux, Carlo Caione
On May 30 2017 or thereabouts, Carlo Caione wrote:
> From: Carlo Caione <carlo@endlessm.com>
>
> We are missing a call to hid_hw_stop() on the remove hook.
> Among other things this is causing an Oops when (re-)starting GNOME /
> upowerd / ... after the module has been already rmmod-ed.
Good catch:
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cheers,
Benjamin
>
> Signed-off-by: Carlo Caione <carlo@endlessm.com>
> ---
> drivers/hid/hid-asus.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/hid/hid-asus.c b/drivers/hid/hid-asus.c
> index 16df6cc..2e9642d 100644
> --- a/drivers/hid/hid-asus.c
> +++ b/drivers/hid/hid-asus.c
> @@ -536,6 +536,8 @@ static void asus_remove(struct hid_device *hdev)
> drvdata->kbd_backlight->removed = true;
> cancel_work_sync(&drvdata->kbd_backlight->work);
> }
> +
> + hid_hw_stop(hdev);
> }
>
> static __u8 *asus_report_fixup(struct hid_device *hdev, __u8 *rdesc,
> --
> 2.9.3
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] HID: asus: Stop underlying hardware on remove
2017-05-30 20:39 [PATCH] HID: asus: Stop underlying hardware on remove Carlo Caione
2017-06-02 7:31 ` Benjamin Tissoires
@ 2017-06-02 12:14 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2017-06-02 12:14 UTC (permalink / raw)
To: Carlo Caione
Cc: benjamin.tissoires, linux-input, linux-kernel, linux,
Carlo Caione
On Tue, 30 May 2017, Carlo Caione wrote:
> From: Carlo Caione <carlo@endlessm.com>
>
> We are missing a call to hid_hw_stop() on the remove hook.
> Among other things this is causing an Oops when (re-)starting GNOME /
> upowerd / ... after the module has been already rmmod-ed.
>
> Signed-off-by: Carlo Caione <carlo@endlessm.com>
Applied to for-4.12/upstream-fixes, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-06-02 12:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-30 20:39 [PATCH] HID: asus: Stop underlying hardware on remove Carlo Caione
2017-06-02 7:31 ` Benjamin Tissoires
2017-06-02 12:14 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).