linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1 1/1] Input: elantech - add Fujitsu Lifebook E546/E557 to force crc_enabled
@ 2017-05-31 18:49 Ulrik De Bie
  2017-06-07 17:31 ` Dmitry Torokhov
  0 siblings, 1 reply; 2+ messages in thread
From: Ulrik De Bie @ 2017-05-31 18:49 UTC (permalink / raw)
  To: Dmitry Torokhov, Arjan Opmeer; +Cc: linux-input, ulrik.debie-os

The Lifebook E546 and E557 touchpad were also not functioning and
worked after running:

        echo "1" > /sys/devices/platform/i8042/serio2/crc_enabled

Add them to the list of machines that need this workaround.

Signed-off-by: Ulrik De Bie <ulrik.debie-os@e2big.org>
Reviewed-by: Arjan Opmeer <arjan@opmeer.net>
---
 drivers/input/mouse/elantech.c | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

The problem was reported by users of those laptops and they confirmed that
the crc_enabled workaround solved it. They were not able to test the patch
though so if anyone else here has such a laptop please feel free to test
the patch !

diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
index e73d968023f7..f1fa1f172107 100644
--- a/drivers/input/mouse/elantech.c
+++ b/drivers/input/mouse/elantech.c
@@ -1118,8 +1118,10 @@ static int elantech_get_resolution_v4(struct psmouse *psmouse,
  * Asus UX32VD             0x361f02        00, 15, 0e      clickpad
  * Avatar AVIU-145A2       0x361f00        ?               clickpad
  * Fujitsu LIFEBOOK E544   0x470f00        d0, 12, 09      2 hw buttons
+ * Fujitsu LIFEBOOK E546   0x470f00        50, 12, 09      2 hw buttons
  * Fujitsu LIFEBOOK E547   0x470f00        50, 12, 09      2 hw buttons
  * Fujitsu LIFEBOOK E554   0x570f01        40, 14, 0c      2 hw buttons
+ * Fujitsu LIFEBOOK E557   0x570f01        40, 14, 0c      2 hw buttons
  * Fujitsu T725            0x470f01        05, 12, 09      2 hw buttons
  * Fujitsu H730            0x570f00        c0, 14, 0c      3 hw buttons (**)
  * Gigabyte U2442          0x450f01        58, 17, 0c      2 hw buttons
@@ -1525,6 +1527,13 @@ static const struct dmi_system_id elantech_dmi_force_crc_enabled[] = {
 		},
 	},
 	{
+		/* Fujitsu LIFEBOOK E546  does not work with crc_enabled == 0 */
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "LIFEBOOK E546"),
+		},
+	},
+	{
 		/* Fujitsu LIFEBOOK E547 does not work with crc_enabled == 0 */
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
@@ -1546,6 +1555,13 @@ static const struct dmi_system_id elantech_dmi_force_crc_enabled[] = {
 		},
 	},
 	{
+		/* Fujitsu LIFEBOOK E557 does not work with crc_enabled == 0 */
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "LIFEBOOK E557"),
+		},
+	},
+	{
 		/* Fujitsu LIFEBOOK U745 does not work with crc_enabled == 0 */
 		.matches = {
 			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
-- 
2.11.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v1 1/1] Input: elantech - add Fujitsu Lifebook E546/E557 to force crc_enabled
  2017-05-31 18:49 [PATCH v1 1/1] Input: elantech - add Fujitsu Lifebook E546/E557 to force crc_enabled Ulrik De Bie
@ 2017-06-07 17:31 ` Dmitry Torokhov
  0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2017-06-07 17:31 UTC (permalink / raw)
  To: Ulrik De Bie; +Cc: Arjan Opmeer, linux-input

On Wed, May 31, 2017 at 08:49:42PM +0200, Ulrik De Bie wrote:
> The Lifebook E546 and E557 touchpad were also not functioning and
> worked after running:
> 
>         echo "1" > /sys/devices/platform/i8042/serio2/crc_enabled
> 
> Add them to the list of machines that need this workaround.
> 
> Signed-off-by: Ulrik De Bie <ulrik.debie-os@e2big.org>
> Reviewed-by: Arjan Opmeer <arjan@opmeer.net>

Applied, thank you.

> ---
>  drivers/input/mouse/elantech.c | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
> 
> The problem was reported by users of those laptops and they confirmed that
> the crc_enabled workaround solved it. They were not able to test the patch
> though so if anyone else here has such a laptop please feel free to test
> the patch !
> 
> diff --git a/drivers/input/mouse/elantech.c b/drivers/input/mouse/elantech.c
> index e73d968023f7..f1fa1f172107 100644
> --- a/drivers/input/mouse/elantech.c
> +++ b/drivers/input/mouse/elantech.c
> @@ -1118,8 +1118,10 @@ static int elantech_get_resolution_v4(struct psmouse *psmouse,
>   * Asus UX32VD             0x361f02        00, 15, 0e      clickpad
>   * Avatar AVIU-145A2       0x361f00        ?               clickpad
>   * Fujitsu LIFEBOOK E544   0x470f00        d0, 12, 09      2 hw buttons
> + * Fujitsu LIFEBOOK E546   0x470f00        50, 12, 09      2 hw buttons
>   * Fujitsu LIFEBOOK E547   0x470f00        50, 12, 09      2 hw buttons
>   * Fujitsu LIFEBOOK E554   0x570f01        40, 14, 0c      2 hw buttons
> + * Fujitsu LIFEBOOK E557   0x570f01        40, 14, 0c      2 hw buttons
>   * Fujitsu T725            0x470f01        05, 12, 09      2 hw buttons
>   * Fujitsu H730            0x570f00        c0, 14, 0c      3 hw buttons (**)
>   * Gigabyte U2442          0x450f01        58, 17, 0c      2 hw buttons
> @@ -1525,6 +1527,13 @@ static const struct dmi_system_id elantech_dmi_force_crc_enabled[] = {
>  		},
>  	},
>  	{
> +		/* Fujitsu LIFEBOOK E546  does not work with crc_enabled == 0 */
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "LIFEBOOK E546"),
> +		},
> +	},
> +	{
>  		/* Fujitsu LIFEBOOK E547 does not work with crc_enabled == 0 */
>  		.matches = {
>  			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
> @@ -1546,6 +1555,13 @@ static const struct dmi_system_id elantech_dmi_force_crc_enabled[] = {
>  		},
>  	},
>  	{
> +		/* Fujitsu LIFEBOOK E557 does not work with crc_enabled == 0 */
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "LIFEBOOK E557"),
> +		},
> +	},
> +	{
>  		/* Fujitsu LIFEBOOK U745 does not work with crc_enabled == 0 */
>  		.matches = {
>  			DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"),
> -- 
> 2.11.0
> 

-- 
Dmitry

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-06-07 17:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-05-31 18:49 [PATCH v1 1/1] Input: elantech - add Fujitsu Lifebook E546/E557 to force crc_enabled Ulrik De Bie
2017-06-07 17:31 ` Dmitry Torokhov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).