public inbox for linux-input@vger.kernel.org
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali.rohar@gmail.com>
To: Daniel Drake <drake@endlessm.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>, linux-input@vger.kernel.org
Subject: Re: [PATCH] Input: psmouse - reset device during probe
Date: Thu, 8 Jun 2017 22:27:50 +0200	[thread overview]
Message-ID: <201706082227.50843@pali> (raw)
In-Reply-To: <CAD8Lp44uQJTro4xqmmSBfhmryZje_d90LNKExNQABak+Kp+FzA@mail.gmail.com>

[-- Attachment #1: Type: Text/Plain, Size: 728 bytes --]

On Thursday 08 June 2017 22:18:36 Daniel Drake wrote:
> On Thu, Jun 8, 2017 at 1:32 PM, Pali Rohár <pali.rohar@gmail.com>
> wrote:
> > This patch will slow down enumeration and initalization of *all*
> > PS/2 mouses.
> 
> I know it's not ideal. but do you think anyone will be able to notice
> the difference in initialization time?

In past I was working on fixing detection of ALPS trackstick and Dmitry 
refused to add another unconditional reset during probe. That problem 
was fixed by calling reset routine only for ALPS devices and after 
detection that it is ALPS...

So I think Dmitry would complain about this unconditional reset for all 
PS/2 devices again.

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

      reply	other threads:[~2017-06-08 20:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-05 20:27 [PATCH] Input: psmouse - reset device during probe Daniel Drake
2017-06-08 19:32 ` Pali Rohár
2017-06-08 20:18   ` Daniel Drake
2017-06-08 20:27     ` Pali Rohár [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201706082227.50843@pali \
    --to=pali.rohar@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=drake@endlessm.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox