Re: [PATCH] Input: joydev - ignore accelerometer devices

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

On Mon, Jun 12, 2017 at 09:09:53AM +0200, Benjamin Tissoires wrote:
> On Jun 09 2017 or thereabouts, Roderick Colenbrander wrote:
> > From: Roderick Colenbrander <roderick.colenbrander@sony.com>
> > 
> > Gamepads like DualShock 3 / 4 as of 4.12 started reporting motion
> > sensors on a separate evdev node. Joydev is picking these devices
> > up as well, but they don't make sense for the joydev interface.
> > 
> > Signed-off-by: Roderick Colenbrander <roderick.colenbrander@sony.com>
> > ---
> 
> Acked-By: Benjamin Tissoires <benjamin.tissoires@redhat.com>

Hmm, I think you can quite often use accelerometer as a joystick, it is
only the composite devices that we want to ignore I think.

> 
> Cheers,
> Benjamin
> 
> >  drivers/input/joydev.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/drivers/input/joydev.c b/drivers/input/joydev.c
> > index 29d677c..a5ceaaf 100644
> > --- a/drivers/input/joydev.c
> > +++ b/drivers/input/joydev.c
> > @@ -819,6 +819,10 @@ static bool joydev_match(struct input_handler *handler, struct input_dev *dev)
> >  	if (joydev_dev_is_absolute_mouse(dev))
> >  		return false;
> >  
> > +	/* Avoid accelerometers */
> > +	if (test_bit(INPUT_PROP_ACCELEROMETER, dev->propbit))
> > +		return false;
> > +
> >  	return true;
> >  }
> >  
> > -- 
> > 2.9.3
> > 

-- 
Dmitry