linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Christopher Bachner <b.christopher.92@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: synaptics - switch t460s 20FN to use RMI4 over SMBus
Date: Tue, 27 Jun 2017 09:53:05 +0200	[thread overview]
Message-ID: <20170627075305.GZ26073@mail.corp.redhat.com> (raw)
In-Reply-To: <20170626153856.GV26073@mail.corp.redhat.com>

On Jun 26 2017 or thereabouts, Benjamin Tissoires wrote:
> On Jun 26 2017 or thereabouts, Christopher Bachner wrote:
> > Hello,
> > 
> > I am assuming that if the inertouch message is not showing up in dmesg,
> > then it is working. Is that a correct assumption?
> > 
> > Either way I also attached my dmesg.
> > 
> > I am not sure, though, why the scroll mode still freezes if I move the my
> > fingers quickly on the touchpad while also using the trackpoint. Is that
> > maybe a future fix and this change is just the foundation for it? Overall
> > the usage of the trackpoint is better now for sure.
> 
> Sadly, you are also hit by:
> [    6.355378] i801_smbus 0000:00:1f.4: BIOS is accessing SMBus registers
> [    6.355380] i801_smbus 0000:00:1f.4: Driver SMBus register access inhibited
> 
> Which disables entirely the RMI4 over SMBus module. And then we can not
> probe for it, meaning you are stuck with the PS/2 crappy mode.
> 
> We are aware of this bug and we'll try to fix that. I think the test you
> provides are valid (the patch works as expected), but a different bug
> prevents rmi-smbus to fully initialize the touchpad :(

Could you try applying Lyude's patch: http://patchwork.ozlabs.org/patch/780865/
(on top of mine, of course).

In the dmesg, you should see a Synaptics TMXXXX device appearing after
trying to set up the SMBus companion.

Cheers,
Benjamin


      reply	other threads:[~2017-06-27  7:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAE4xfVLxhF29jLoFWwa4o6_0G_5VMQ8YN1BVP4=8+Y3u_BERPw@mail.gmail.com>
2017-06-26  8:26 ` [PATCH] Input: synaptics - switch t460s 20FN to use RMI4 over SMBus Benjamin Tissoires
     [not found]   ` <CAE4xfV+Z8Yq=5rGP7H5CcWYfJrNLDPVjgqFOb_ebk0QOYat7Hw@mail.gmail.com>
     [not found]     ` <CAE4xfV+ygZ5Z9VsFdzmkQQgZZyH79zM4Jr2PHS2s0b9NYG7fqQ@mail.gmail.com>
2017-06-26 15:38       ` Benjamin Tissoires
2017-06-27  7:53         ` Benjamin Tissoires [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170627075305.GZ26073@mail.corp.redhat.com \
    --to=benjamin.tissoires@redhat.com \
    --cc=b.christopher.92@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).