From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pali =?utf-8?B?Um9ow6Fy?= Subject: Re: Spurious touchpad events with closed LID Date: Thu, 29 Jun 2017 09:31:02 +0200 Message-ID: <20170629073102.GG25196@pali> References: <201706261854.53970@pali> <20170626170312.GB4965@dtor-ws> <201706262109.42628@pali> <20170628201530.GB18101@amd> <1498689867.6564.6.camel@hadess.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from mail-wm0-f67.google.com ([74.125.82.67]:35276 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751878AbdF2HbG (ORCPT ); Thu, 29 Jun 2017 03:31:06 -0400 Content-Disposition: inline In-Reply-To: <1498689867.6564.6.camel@hadess.net> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Bastien Nocera Cc: Pavel Machek , Dmitry Torokhov , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org On Thursday 29 June 2017 00:44:27 Bastien Nocera wrote: > On Wed, 2017-06-28 at 22:15 +0200, Pavel Machek wrote: > > > > > While policy normally belongs to userspace, I'd argue this is > > workaround for a hardware bug, and in-kernel solution would be > > acceptable. > > > > Anyway, disable attribute would be nice first step. > > It's already fixed for those of us on recent distributions. The > "ID_INPUT_TOUCHPAD_INTEGRATION=internal" touchpads will be disabled > when the lid is closed, when libinput is used to process the events. But this does not fix other usage of /dev/input/* and also does not fix pressing spurious keys in linux virtual tty (ctrl+alt+f1). So it is not a fix. Also important question is: How you detect which input device is "internal", non-removable part of notebook and which one is external? You can have external USB touchpad, and also you can have external PS/2 keyboard connected to docking station (which was e.g. my situation). Also there are PS/2 to active USB converters, to make whole situation complicated. And moreover some internal notebook keyboards are connected via USB and some touchpads via i2c/smbus. I think this detection is not easy or at least I have no idea how to do properly. Existence of PS/2 keyboard does not mean it is internal and existence of USB keyboard does not mean it is external. Maybe ACPI/DSDT provides some information? (No idea, just asking) > Usually, non-crappy hardware will do that in firmware, but software is > easier to patch ;) -- Pali Rohár pali.rohar@gmail.com