From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: Spurious touchpad events with closed LID Date: Thu, 29 Jun 2017 12:15:00 +0200 Message-ID: <20170629101500.GB1709@amd> References: <201706261854.53970@pali> <20170626170312.GB4965@dtor-ws> <201706262109.42628@pali> <20170628201530.GB18101@amd> <1498689867.6564.6.camel@hadess.net> <20170629073102.GG25196@pali> <20170629100837.GA1709@amd> <20170629101112.GK25196@pali> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="neYutvxvOLaeuPCA" Return-path: Content-Disposition: inline In-Reply-To: <20170629101112.GK25196@pali> Sender: linux-kernel-owner@vger.kernel.org To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Bastien Nocera , Dmitry Torokhov , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org List-Id: linux-input@vger.kernel.org --neYutvxvOLaeuPCA Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu 2017-06-29 12:11:12, Pali Roh=E1r wrote: > On Thursday 29 June 2017 12:08:37 Pavel Machek wrote: > > Hi! > >=20 > > On Thu 2017-06-29 09:31:02, Pali Roh=E1r wrote: > > > On Thursday 29 June 2017 00:44:27 Bastien Nocera wrote: > > > > On Wed, 2017-06-28 at 22:15 +0200, Pavel Machek wrote: > > > > >=20 > > > > > > > > > While policy normally belongs to userspace, I'd argue this is > > > > > workaround for a hardware bug, and in-kernel solution would be > > > > > acceptable. > > > > >=20 > > > > > Anyway, disable attribute would be nice first step. > > > >=20 > > > > It's already fixed for those of us on recent distributions. The > > > > "ID_INPUT_TOUCHPAD_INTEGRATION=3Dinternal" touchpads will be disabl= ed > > > > when the lid is closed, when libinput is used to process the events. > > >=20 > > > But this does not fix other usage of /dev/input/* and also does not f= ix > > > pressing spurious keys in linux virtual tty (ctrl+alt+f1). So it is n= ot > > > a fix. > > >=20 > > > Also important question is: How you detect which input device is > > > "internal", non-removable part of notebook and which one is external? > > >=20 > > > You can have external USB touchpad, and also you can have external PS= /2 > > > keyboard connected to docking station (which was e.g. my situation). > > >=20 > > > Also there are PS/2 to active USB converters, to make whole situation > > > complicated. > > >=20 > > > And moreover some internal notebook keyboards are connected via USB a= nd > > > some touchpads via i2c/smbus. > > >=20 > > > I think this detection is not easy or at least I have no idea how to = do > > > properly. Existence of PS/2 keyboard does not mean it is internal and > > > existence of USB keyboard does not mean it is external. > > >=20 > > > Maybe ACPI/DSDT provides some information? (No idea, just asking) > >=20 > > I'm not sure it is complex. You simply add DMI blacklist of the bad > > systems, with IDs of bad devices. >=20 > My original request is to disable internal keyboard, touchpad and > trackpoint on notebook when it is docked and LID is closed. >=20 > It has nothing to do with DMI blacklist or so. Well, you have a buggy notebook. On non-buggy ones, touchpad will not generate events when closed. That's where the DMI blacklist comes to mind. (Of course, disable attribute would still be nice for other cases.) Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --neYutvxvOLaeuPCA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAllU0yQACgkQMOfwapXb+vLgKACfeFvhsRRxGO1MxxESSxIaXO3J +iwAniLmHj7xiLgDfHzoWXAMO9UdeEsf =MfBs -----END PGP SIGNATURE----- --neYutvxvOLaeuPCA--