linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali.rohar@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Bastien Nocera <hadess@hadess.net>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: Spurious touchpad events with closed LID
Date: Thu, 29 Jun 2017 12:24:35 +0200	[thread overview]
Message-ID: <20170629102435.GL25196@pali> (raw)
In-Reply-To: <20170629101500.GB1709@amd>

On Thursday 29 June 2017 12:15:00 Pavel Machek wrote:
> On Thu 2017-06-29 12:11:12, Pali Rohár wrote:
> > On Thursday 29 June 2017 12:08:37 Pavel Machek wrote:
> > > Hi!
> > > 
> > > On Thu 2017-06-29 09:31:02, Pali Rohár wrote:
> > > > On Thursday 29 June 2017 00:44:27 Bastien Nocera wrote:
> > > > > On Wed, 2017-06-28 at 22:15 +0200, Pavel Machek wrote:
> > > > > > 
> > > > > <snip>
> > > > > > While policy normally belongs to userspace, I'd argue this is
> > > > > > workaround for a hardware bug, and in-kernel solution would be
> > > > > > acceptable.
> > > > > > 
> > > > > > Anyway, disable attribute would be nice first step.
> > > > > 
> > > > > It's already fixed for those of us on recent distributions. The
> > > > > "ID_INPUT_TOUCHPAD_INTEGRATION=internal" touchpads will be disabled
> > > > > when the lid is closed, when libinput is used to process the events.
> > > > 
> > > > But this does not fix other usage of /dev/input/* and also does not fix
> > > > pressing spurious keys in linux virtual tty (ctrl+alt+f1). So it is not
> > > > a fix.
> > > > 
> > > > Also important question is: How you detect which input device is
> > > > "internal", non-removable part of notebook and which one is external?
> > > > 
> > > > You can have external USB touchpad, and also you can have external PS/2
> > > > keyboard connected to docking station (which was e.g. my situation).
> > > > 
> > > > Also there are PS/2 to active USB converters, to make whole situation
> > > > complicated.
> > > > 
> > > > And moreover some internal notebook keyboards are connected via USB and
> > > > some touchpads via i2c/smbus.
> > > > 
> > > > I think this detection is not easy or at least I have no idea how to do
> > > > properly. Existence of PS/2 keyboard does not mean it is internal and
> > > > existence of USB keyboard does not mean it is external.
> > > > 
> > > > Maybe ACPI/DSDT provides some information? (No idea, just asking)
> > > 
> > > I'm not sure it is complex. You simply add DMI blacklist of the bad
> > > systems, with IDs of bad devices.
> > 
> > My original request is to disable internal keyboard, touchpad and
> > trackpoint on notebook when it is docked and LID is closed.
> > 
> > It has nothing to do with DMI blacklist or so.
> 
> Well, you have a buggy notebook. On non-buggy ones, touchpad will not
> generate events when closed.
> 
> That's where the DMI blacklist comes to mind.

Such blacklist would be huge. Lot of notebooks working in this way.

> (Of course, disable attribute would still be nice for other cases.)

Yes.

-- 
Pali Rohár
pali.rohar@gmail.com

  reply	other threads:[~2017-06-29 10:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-26 16:54 Spurious touchpad events with closed LID Pali Rohár
2017-06-26 17:03 ` Dmitry Torokhov
2017-06-26 19:09   ` Pali Rohár
2017-06-28 20:15     ` Pavel Machek
2017-06-28 22:44       ` Bastien Nocera
2017-06-29  7:31         ` Pali Rohár
2017-06-29 10:08           ` Pavel Machek
2017-06-29 10:11             ` Pali Rohár
2017-06-29 10:15               ` Pavel Machek
2017-06-29 10:24                 ` Pali Rohár [this message]
2017-06-29 10:37           ` Bastien Nocera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170629102435.GL25196@pali \
    --to=pali.rohar@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=hadess@hadess.net \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).