From: Guenter Roeck <linux@roeck-us.net>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Sebastian Reichel <sebastian.reichel@collabora.co.uk>,
Sebastian Reichel <sre@kernel.org>,
Support Opensource <support.opensource@diasemi.com>,
Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Jean Delvare <jdelvare@suse.com>,
devicetree@vger.kernel.org, linux-hwmon@vger.kernel.org,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3 4/4] hwmon: da9052: add support for TSI channel
Date: Thu, 29 Jun 2017 15:44:57 -0700 [thread overview]
Message-ID: <20170629224457.GA4360@roeck-us.net> (raw)
In-Reply-To: <20170629184521.GA38388@dtor-ws>
On Thu, Jun 29, 2017 at 11:45:21AM -0700, Dmitry Torokhov wrote:
> Hi Sebastian,
>
> On Thu, Jun 29, 2017 at 02:43:46PM +0200, Sebastian Reichel wrote:
> > @@ -238,6 +239,14 @@ static int da9052_ts_probe(struct platform_device *pdev)
> > if (!da9052)
> > return -EINVAL;
> >
> > + /*
> > + * Check if touchscreen pins are used are analogue input instead
> > + * of having a touchscreen connected to them. The analogue input
> > + * functionality will be provided by hwmon driver (if enabled).
> > + */
> > + if (device_property_read_bool(pdev->dev.parent, "dlg,tsi-as-adc"))
> > + return -ENODEV;
> > +
>
> I believe this is not the right way of doing this. da9052-core should
> simply forgo creating da9052-tsi platform device when this property is
> present.
>
Agreed.
Guenter
prev parent reply other threads:[~2017-06-29 22:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-29 12:43 [PATCHv3 0/4] DA9052 hardware monitoring improvements Sebastian Reichel
2017-06-29 12:43 ` [PATCHv3 1/4] mfd: da9052: fix manual ADC read after timed out read Sebastian Reichel
2017-06-29 12:43 ` [PATCHv3 2/4] hwmon: da9052: replace S_IRUGO with 0444 Sebastian Reichel
[not found] ` <20170629124346.22325-1-sebastian.reichel-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2017-06-29 12:43 ` [PATCHv3 3/4] dt-bindings: mfd: da9052: support TSI as ADC Sebastian Reichel
2017-06-29 12:43 ` [PATCHv3 4/4] hwmon: da9052: add support for TSI channel Sebastian Reichel
2017-06-29 18:45 ` Dmitry Torokhov
2017-06-29 22:44 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170629224457.GA4360@roeck-us.net \
--to=linux@roeck-us.net \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jdelvare@suse.com \
--cc=lee.jones@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.co.uk \
--cc=sre@kernel.org \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).