From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Torokhov Subject: Re: [PATCH] input: serio: constify attribute_group structures. Date: Mon, 10 Jul 2017 20:25:30 -0700 Message-ID: <20170711032530.GA13313@dtor-ws> References: <4448ab728b41d7e7648777cd90bcd3096da711bf.1499247619.git.arvind.yadav.cs@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pg0-f67.google.com ([74.125.83.67]:35027 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755118AbdGKDZe (ORCPT ); Mon, 10 Jul 2017 23:25:34 -0400 Content-Disposition: inline In-Reply-To: <4448ab728b41d7e7648777cd90bcd3096da711bf.1499247619.git.arvind.yadav.cs@gmail.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Arvind Yadav Cc: benjamin.tissoires@redhat.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org On Wed, Jul 05, 2017 at 03:12:53PM +0530, Arvind Yadav wrote: > attribute_groups are not supposed to change at runtime. All functions > working with attribute_groups provided by work with const > attribute_group. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 6862 1008 4 7874 1ec2 drivers/input/serio/serio.o > > File size After adding 'const': > text data bss dec hex filename > 6990 880 4 7874 1ec2 drivers/input/serio/serio.o > > Signed-off-by: Arvind Yadav Thanks, I'll queue this and the rest for 4.14. > --- > drivers/input/serio/serio.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/input/serio/serio.c b/drivers/input/serio/serio.c > index 30d6230..24a90c8 100644 > --- a/drivers/input/serio/serio.c > +++ b/drivers/input/serio/serio.c > @@ -469,7 +469,7 @@ static ssize_t firmware_id_show(struct device *dev, struct device_attribute *att > NULL > }; > > -static struct attribute_group serio_id_attr_group = { > +static const struct attribute_group serio_id_attr_group = { > .name = "id", > .attrs = serio_device_id_attrs, > }; > @@ -489,7 +489,7 @@ static ssize_t firmware_id_show(struct device *dev, struct device_attribute *att > NULL > }; > > -static struct attribute_group serio_device_attr_group = { > +static const struct attribute_group serio_device_attr_group = { > .attrs = serio_device_attrs, > }; > > -- > 1.9.1 > -- Dmitry