* [PATCH RESEND] HID: wacom: Remove comparison of u8 mode with zero and simplify.
@ 2017-07-08 19:25 Christos Gkekas
2017-07-12 7:39 ` Benjamin Tissoires
2017-07-20 13:43 ` Jiri Kosina
0 siblings, 2 replies; 3+ messages in thread
From: Christos Gkekas @ 2017-07-08 19:25 UTC (permalink / raw)
To: Joe Perches, Jiri Kosina, Benjamin Tissoires, linux-input,
linux-kernel
Cc: Christos Gkekas
Variable mode in method wacom_show_remote_mode() is defined as u8, thus
statement (mode >= 0) is always true and should be removed, simplifying
the logic.
Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
---
drivers/hid/wacom_sys.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
index 838c1eb..ae2408d 100644
--- a/drivers/hid/wacom_sys.c
+++ b/drivers/hid/wacom_sys.c
@@ -1671,10 +1671,7 @@ static ssize_t wacom_show_remote_mode(struct kobject *kobj,
u8 mode;
mode = wacom->led.groups[index].select;
- if (mode >= 0 && mode < 3)
- return snprintf(buf, PAGE_SIZE, "%d\n", mode);
- else
- return snprintf(buf, PAGE_SIZE, "%d\n", -1);
+ return sprintf(buf, "%d\n", mode < 3 ? mode : -1);
}
#define DEVICE_EKR_ATTR_GROUP(SET_ID) \
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] HID: wacom: Remove comparison of u8 mode with zero and simplify.
2017-07-08 19:25 [PATCH RESEND] HID: wacom: Remove comparison of u8 mode with zero and simplify Christos Gkekas
@ 2017-07-12 7:39 ` Benjamin Tissoires
2017-07-20 13:43 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Benjamin Tissoires @ 2017-07-12 7:39 UTC (permalink / raw)
To: Christos Gkekas; +Cc: Joe Perches, Jiri Kosina, linux-input, linux-kernel
On Jul 08 2017 or thereabouts, Christos Gkekas wrote:
> Variable mode in method wacom_show_remote_mode() is defined as u8, thus
> statement (mode >= 0) is always true and should be removed, simplifying
> the logic.
>
> Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
> ---
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> drivers/hid/wacom_sys.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/hid/wacom_sys.c b/drivers/hid/wacom_sys.c
> index 838c1eb..ae2408d 100644
> --- a/drivers/hid/wacom_sys.c
> +++ b/drivers/hid/wacom_sys.c
> @@ -1671,10 +1671,7 @@ static ssize_t wacom_show_remote_mode(struct kobject *kobj,
> u8 mode;
>
> mode = wacom->led.groups[index].select;
> - if (mode >= 0 && mode < 3)
> - return snprintf(buf, PAGE_SIZE, "%d\n", mode);
> - else
> - return snprintf(buf, PAGE_SIZE, "%d\n", -1);
> + return sprintf(buf, "%d\n", mode < 3 ? mode : -1);
> }
>
> #define DEVICE_EKR_ATTR_GROUP(SET_ID) \
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] HID: wacom: Remove comparison of u8 mode with zero and simplify.
2017-07-08 19:25 [PATCH RESEND] HID: wacom: Remove comparison of u8 mode with zero and simplify Christos Gkekas
2017-07-12 7:39 ` Benjamin Tissoires
@ 2017-07-20 13:43 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2017-07-20 13:43 UTC (permalink / raw)
To: Christos Gkekas
Cc: Joe Perches, Benjamin Tissoires, linux-input, linux-kernel
On Sat, 8 Jul 2017, Christos Gkekas wrote:
> Variable mode in method wacom_show_remote_mode() is defined as u8, thus
> statement (mode >= 0) is always true and should be removed, simplifying
> the logic.
>
> Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
Applied to for-4.14/wacom, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-07-20 13:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-08 19:25 [PATCH RESEND] HID: wacom: Remove comparison of u8 mode with zero and simplify Christos Gkekas
2017-07-12 7:39 ` Benjamin Tissoires
2017-07-20 13:43 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).