From: Peter Hutterer <peter.hutterer@who-t.net>
To: Florian Echtler <floe@butterbrot.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, Martin Kaltenbrunner <modin@yuri.at>
Subject: Re: [PATCH 2/2] skip all blobs that are not touches
Date: Fri, 14 Jul 2017 18:24:06 +1000 [thread overview]
Message-ID: <20170714082406.GA29703@jelly> (raw)
In-Reply-To: <alpine.DEB.2.10.1707140951540.18874@butterbrot>
On Fri, Jul 14, 2017 at 09:54:03AM +0200, Florian Echtler wrote:
> On Mon, 10 Jul 2017, Dmitry Torokhov wrote:
> > On Mon, Jul 10, 2017 at 09:11:53AM +0200, Florian Echtler wrote:
> > >
> > > Related question: we first attempted to label non-touch objects as MT_TOOL_PALM,
> > > but it looks like userspace (Xorg in particular) doesn't actually distinguish
> > > between MT_TOOL_* types; is that correct?
> >
> > It really should, but I think Peter never got around implementing this.
> >
> > Also, I think it is a good idea to set touch major to max in this case.
> > I believe that that will help clients that do no understand MT_TOOL_PALM
> > to still do palm rejection.
> >
> > Peter?
>
> Would you consider merging v2 of the patch regardless of the Xorg situation?
> Right now, it's a useful bugfix in any case, and we can deal with how to
> represent blobs/palms/tokens later on.
sorry about the delay, bit chaotic here. libinput 1.8 was released a week or
so ago and it supports MT_TOOL_PALM, so consider userspace ready for that. I
also have patches to use major/minor for palm detection where appropriate
which will hit git master (my) tonight.
That's the libinput situation sorted I think, don't expect synaptics to
catch up with that though (unless someone ends up writing the patches).
Cheers,
Peter
next prev parent reply other threads:[~2017-07-14 8:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-09 18:54 [PATCH 1/2] add additional reverse-engineered information Florian Echtler
2017-07-09 18:54 ` [PATCH 2/2] skip all blobs that are not touches Florian Echtler
2017-07-09 21:41 ` Dmitry Torokhov
2017-07-10 7:11 ` Florian Echtler
2017-07-10 18:11 ` Dmitry Torokhov
2017-07-14 7:54 ` Florian Echtler
2017-07-14 8:24 ` Peter Hutterer [this message]
2017-07-14 9:28 ` Florian Echtler
2017-07-14 22:13 ` Peter Hutterer
2017-07-09 21:40 ` [PATCH 1/2] add additional reverse-engineered information Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170714082406.GA29703@jelly \
--to=peter.hutterer@who-t.net \
--cc=dmitry.torokhov@gmail.com \
--cc=floe@butterbrot.org \
--cc=linux-input@vger.kernel.org \
--cc=modin@yuri.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).