Re: [PATCH] Input: add support for HiDeep touchscreen

[Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

On Tue, Jul 11, 2017 at 05:01:47PM +0900, 김태영 wrote:
> 2017-07-10 10:17 GMT+09:00 Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>:
> >
> > On Wed, Jul 05, 2017 at 03:19:48PM +0900, Anthony Kim wrote:
> > > The HiDeep touchscreen device is a capacitive multi-touch controller
> > > mainly for multi-touch supported devices use. It use I2C interface for
> > > communication to IC and provide axis X, Y, Z locations for ten finger
> > > touch through input event interface to userspace.
> > >
> > > It support the Crimson and the Lime two type IC. They are different
> > > the number of channel supported and FW size. But the working protocol
> > > is same.
> > >
> > > Signed-off-by: Anthony Kim <anthony.kim-7TZDMcjUQMzQT0dZR+AlfA@public.gmane.org>
> > > ---
> > >  .../bindings/input/touchscreen/hideep.txt          |   40 +
> > >  .../devicetree/bindings/vendor-prefixes.txt        |    1 +
> > >  drivers/input/touchscreen/Kconfig                  |   32 +
> > >  drivers/input/touchscreen/Makefile                 |    2 +
> > >  drivers/input/touchscreen/hideep.h                 |  338 +++++++
> > >  drivers/input/touchscreen/hideep_core.c            | 1029 ++++++++++++++++++++
> > >  drivers/input/touchscreen/hideep_dbg.c             |  405 ++++++++
> > >  drivers/input/touchscreen/hideep_dbg.h             |   24 +
> > >  drivers/input/touchscreen/hideep_isp.c             |  584 +++++++++++
> > >  drivers/input/touchscreen/hideep_isp.h             |   96 ++
> > >  drivers/input/touchscreen/hideep_sysfs.c           |  249 +++++
> > >  11 files changed, 2800 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/input/touchscreen/hideep.txt
> > >  create mode 100644 drivers/input/touchscreen/hideep.h
> > >  create mode 100644 drivers/input/touchscreen/hideep_core.c
> > >  create mode 100644 drivers/input/touchscreen/hideep_dbg.c
> > >  create mode 100644 drivers/input/touchscreen/hideep_dbg.h
> > >  create mode 100644 drivers/input/touchscreen/hideep_isp.c
> > >  create mode 100644 drivers/input/touchscreen/hideep_isp.h
> > >  create mode 100644 drivers/input/touchscreen/hideep_sysfs.c
> > >
> > > diff --git a/Documentation/devicetree/bindings/input/touchscreen/hideep.txt b/Documentation/devicetree/bindings/input/touchscreen/hideep.txt
> > > new file mode 100644
> > > index 0000000..f5ab5e6
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/input/touchscreen/hideep.txt
> > > @@ -0,0 +1,40 @@
> > > +* HiDeep Finger and Stylus touchscreen controller
> > > +
> > > +Required properties:
> > > +- compatible         : must be "hideep,hideep_ts".
> >
> > s/_/-/
> >
> > Is there only 1 version or another way to determine the exact chip and
> > firmware? If not, then you need a more specific compatible.
> 
> Yes, we have to determine the chip and firmware through the firmware file name
>  and reading I2C about info.

How do you determine the firmware filename then?

> Also the chip can select by kernel config.

If the kernel knows the specific chip, then the DT certainly should have 
that.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html