* [PATCH] HID: input: throttle battery uevents
@ 2017-08-10 19:47 Dmitry Torokhov
2017-08-15 8:56 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Torokhov @ 2017-08-10 19:47 UTC (permalink / raw)
To: Jiri Kosina; +Cc: Benjamin Tissoires, Jason Gerecke, linux-input, linux-kernel
The power_supply subsystem tends to emit uevent every time
power_supply_changed() is called, so we should call this API only when
battery strength reported by the device is actually different from the
previous readings, otherwise we'll drown the system in uevents.
Fixes: 581c4484769e ("HID: input: map digitizer battery usage")
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/hid/hid-input.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
index 27d8442b017d..199f6a01fc62 100644
--- a/drivers/hid/hid-input.c
+++ b/drivers/hid/hid-input.c
@@ -520,15 +520,21 @@ static void hidinput_cleanup_battery(struct hid_device *dev)
static void hidinput_update_battery(struct hid_device *dev, int value)
{
+ int capacity;
+
if (!dev->battery)
return;
if (value == 0 || value < dev->battery_min || value > dev->battery_max)
return;
- dev->battery_capacity = hidinput_scale_battery_capacity(dev, value);
- dev->battery_reported = true;
- power_supply_changed(dev->battery);
+ capacity = hidinput_scale_battery_capacity(dev, value);
+
+ if (!dev->battery_reported || capacity != dev->battery_capacity) {
+ dev->battery_capacity = capacity;
+ dev->battery_reported = true;
+ power_supply_changed(dev->battery);
+ }
}
#else /* !CONFIG_HID_BATTERY_STRENGTH */
static int hidinput_setup_battery(struct hid_device *dev, unsigned report_type,
--
2.14.0.434.g98096fd7a8-goog
--
Dmitry
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] HID: input: throttle battery uevents
2017-08-10 19:47 [PATCH] HID: input: throttle battery uevents Dmitry Torokhov
@ 2017-08-15 8:56 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2017-08-15 8:56 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Benjamin Tissoires, Jason Gerecke, linux-input, linux-kernel
On Thu, 10 Aug 2017, Dmitry Torokhov wrote:
> The power_supply subsystem tends to emit uevent every time
> power_supply_changed() is called, so we should call this API only when
> battery strength reported by the device is actually different from the
> previous readings, otherwise we'll drown the system in uevents.
>
> Fixes: 581c4484769e ("HID: input: map digitizer battery usage")
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Applied to for-4.14/battery. Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-08-15 8:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-10 19:47 [PATCH] HID: input: throttle battery uevents Dmitry Torokhov
2017-08-15 8:56 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).