linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Takashi Iwai <tiwai@suse.de>,
	alsa-devel@alsa-project.org, linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org, kbuild-all@01.org
Subject: Re: [PATCH] input/keyboard: fix platform_no_drv_owner.cocci warnings
Date: Sun, 20 Aug 2017 09:28:41 -0700	[thread overview]
Message-ID: <20170820162841.GA1176@dtor-ws> (raw)
In-Reply-To: <alpine.DEB.2.20.1708201118140.3678@hadrien>

On Sun, Aug 20, 2017 at 11:19:38AM +0200, Julia Lawall wrote:
> No need to set .owner here. The core will do it.
> 
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
> 
> Fixes: 52cf590518d7 ("input/keyboard: Add support for Dollar Cove TI power button")
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> 
>  dc_ti_pwrbtn.c |    1 -

Hm, this driver is neither in my tree nor in next; where is it coming
from?

>  1 file changed, 1 deletion(-)
> 
> --- a/drivers/input/keyboard/dc_ti_pwrbtn.c
> +++ b/drivers/input/keyboard/dc_ti_pwrbtn.c
> @@ -75,7 +75,6 @@ static int dc_ti_pwrbtn_probe(struct pla
>  static struct platform_driver dc_ti_pwrbtn_driver = {
>  	.driver = {
>  		.name = DRIVER_NAME,
> -		.owner = THIS_MODULE,
>  	},
>  	.probe	= dc_ti_pwrbtn_probe,
>  };

-- 
Dmitry

  reply	other threads:[~2017-08-20 16:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-20  9:19 [PATCH] input/keyboard: fix platform_no_drv_owner.cocci warnings Julia Lawall
2017-08-20 16:28 ` Dmitry Torokhov [this message]
2017-08-20 16:44   ` Julia Lawall
2017-08-20 20:35   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170820162841.GA1176@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=julia.lawall@lip6.fr \
    --cc=kbuild-all@01.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).